Giter Site home page Giter Site logo

Comments (9)

Jean85 avatar Jean85 commented on May 30, 2024

Nice!

from paraunit.

ranpafin avatar ranpafin commented on May 30, 2024

Supported events are now:

  • engine.before_start ( listen by SharkPrinter)
  • engine.start ( nothing atm )
  • engine.end ( listen by FinalPrinter)
  • process.started ( nothing atm)
  • process.terminated ( listen by RetryManager, ProcessOutputPrinter)

The runner lost most of his dependency and feel more clean.

from paraunit.

Jean85 avatar Jean85 commented on May 30, 2024

All done in 21c55b7 right? Good!
I think I will use process.terminated in #11

from paraunit.

Jean85 avatar Jean85 commented on May 30, 2024

Should we release this with 0.5?

from paraunit.

Jean85 avatar Jean85 commented on May 30, 2024

I had to fix the listeners priority: c26e787

from paraunit.

ranpafin avatar ranpafin commented on May 30, 2024

Yes i can see that. Good catch!

It's a shame we had to put a priority for events... I'll look into making those methods commutative. If it is possible.

from paraunit.

Jean85 avatar Jean85 commented on May 30, 2024

The priority was the quick fix.
Maybe we can change the behaviour a little, with the printer triggered by the parser in some way (directly? with a new event?)
Also, the parser is not required if the retry is needed. Do you think it'll be a good idea to take the RetryManager and convert it to a parser? It will become the first of the chain...

from paraunit.

ranpafin avatar ranpafin commented on May 30, 2024

Yes i think it would make sense moving it to the perser list, at the moment the retry parser feels kinda void...
We could merge those 2 and give more purpose to the current parser.

from paraunit.

Jean85 avatar Jean85 commented on May 30, 2024

Ok, I've open a new issue ( #21 ) for the refactoring, I'm closing this, it's all done for now, we can use the events as they are.

from paraunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.