Giter Site home page Giter Site logo

Comments (5)

krisimmig avatar krisimmig commented on September 27, 2024

A working version is now in this feature, anybody wants to do some testing?

16-svg-sprite-loader/packages/svg-sprite

Some open questions:

  • is removing the fill and stroke colors from all svgs a good idea?
    I think it it is much easier that way to style them with css, but more complex SVGs will loose the coloring all together.
  • is this also working in IE11 and Edge?
    Haven't tested this, yet.
  • something else missing?

from factorial-frontend-stack.

mlnmln avatar mlnmln commented on September 27, 2024

@krisimmig I'll have a look today – sorry for the late feedback.

from factorial-frontend-stack.

mlnmln avatar mlnmln commented on September 27, 2024

I can't get this running in the example folder after 30m trying out.
Could you provide a PR with changes in the example folder that get this running? Thanks.

Some concerns:

  • How would this work in a twig template / PHP environment? How does the spritemap get injected in that case?
  • Does this conflict with our existing file loader? We import svg fonts in CSS in our usage example?
  • For IE11 compatbility we usually need this polyfill here https://github.com/jonathantneal/svg4everybody is that included?

from factorial-frontend-stack.

krisimmig avatar krisimmig commented on September 27, 2024
  • the spritemap is injected by the sprite-loader itself
  • there is a conflict when loading svg files from css at the moment which causes an error in the build
  • IE11 is working without the ployfill

I will try to fix the svg import from css files..

from factorial-frontend-stack.

mlnmln avatar mlnmln commented on September 27, 2024

Sounds good to me. I pushed some changes a couple of days back. Make sure to pulle them.

from factorial-frontend-stack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.