Comments (5)
A working version is now in this feature, anybody wants to do some testing?
16-svg-sprite-loader/packages/svg-sprite
Some open questions:
- is removing the fill and stroke colors from all svgs a good idea?
I think it it is much easier that way to style them with css, but more complex SVGs will loose the coloring all together. - is this also working in IE11 and Edge?
Haven't tested this, yet. - something else missing?
from factorial-frontend-stack.
@krisimmig I'll have a look today – sorry for the late feedback.
from factorial-frontend-stack.
I can't get this running in the example folder after 30m trying out.
Could you provide a PR with changes in the example folder that get this running? Thanks.
Some concerns:
- How would this work in a twig template / PHP environment? How does the spritemap get injected in that case?
- Does this conflict with our existing file loader? We import svg fonts in CSS in our usage example?
- For IE11 compatbility we usually need this polyfill here https://github.com/jonathantneal/svg4everybody is that included?
from factorial-frontend-stack.
- the spritemap is injected by the sprite-loader itself
- there is a conflict when loading svg files from css at the moment which causes an error in the build
- IE11 is working without the ployfill
I will try to fix the svg import from css files..
from factorial-frontend-stack.
Sounds good to me. I pushed some changes a couple of days back. Make sure to pulle them.
from factorial-frontend-stack.
Related Issues (20)
- neutrino setup doesn't transpile ES6 code as expected. HOT 1
- Fix: Avoid build changes when no files actually changed HOT 4
- Provide export PostCSS variables
- Feat: Build external source maps when production
- Feat: @factorial/frontend-stack-vue
- Investigate lerna versioning mode
- Chore: Fix peer dependency warnings
- include() in yaml files not working HOT 1
- Errors when generating patternlab HOT 3
- Chore: Resolve webpack-file-watcher warnings HOT 2
- Docs: Provide example for changing glob options
- Feat: Make ENV settings for path configurable HOT 2
- Feat: post css custom properties preserve should be false
- Fix: pattern lab build does not exit
- Feat: Make jsdoc comment blocks mandatory HOT 1
- Feat: Conventional change logs
- Chore: Upgrade eslint config airbnb base
- Docs: Update pattern lab package
- Refactor core to allow pick and choosing of features HOT 2
- Feat: Build CSS sourcemaps in production
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from factorial-frontend-stack.