Comments (9)
It's a good practice to mark classes as final unless they're specifically designed with inheritance in mind. In this case, I don't see a problem, though I do have to ask, why not just create an instance of RetryPolicy that handles the exceptions you want and copy it if needed?
RetryPolicy basePolicy = new RetryPolicy().retryOn(apacheHttpExceptions);
public RetryPolicy newPolicy() {
return basePolicy.copy();
}
from failsafe.
Because I want to use it in other Classes as well and with inheritance it is Mord convenient.
Besides that I'd like to give Circuitbreakers additional properties in Order to be able to identify them for monitoring reasons.
from failsafe.
@MALPI Fair enough. Done!
I've been asked about having a CircuitBreaker registry or some sort of named tracking for CircuitBreakers, but for now I think that's best left to users to track circuit breakers however they want, via a Map or DI framework or whatever works best for them. And rather than adding a name to circuit breakers, that's how I would do it - by tracking them externally:
class CircuitBreakerRegistry {
ConcurrentMap<String, CircuitBreaker> breakers = new ConcurrentHashMap<>();
public CircuitBreaker breakerFor(String name) {
return breakers.computeIfAbsent(key, k -> new CircuitBreaker().....);
}
}
But whatever works for you!
from failsafe.
Thanks a lot for your Quick response and your input! Really like failsafe so far!
from failsafe.
@MALPI Thanks. If you like it, please spread the word :)
from failsafe.
Did so ;-) See twitter... will promoted it also in the company. ;-)
from failsafe.
Can you release a new version for that?
from failsafe.
I have some other changes waiting to go in before a release, but hopefully after this weekend.
from failsafe.
Released
from failsafe.
Related Issues (20)
- Why does CheckedPredicate exist? HOT 2
- Also add note about default maxRetries of 3 to maxDuration section of the documentation HOT 7
- Bulkhead policy may drop requests when maxWaitTime is specified HOT 8
- Guidance around CheckedPredicate HOT 2
- Time based error limiter policy
- [Question]Can withBackoff and withDelay be used at the same time? HOT 2
- RetryPolicy handleIf not working with DynamoDbException in predicate HOT 4
- Having a context object in the run(...) and get(...) methods HOT 7
- dev.failsafe.Functions.* do not propagate toString to the wrapped object
- [Question] Is it possible to have multiple Fallback policies in one Failsafe executor? HOT 4
- [question] how to use failsafe with kotlin
- Feature Request: Integrate / add support for Lunar Proxy (backend policy) HOT 1
- Why recommend CircuitBreaker before Retry? HOT 1
- CircuitBreaker stays in OPEN even after DELAY time HOT 1
- Nested retries, how to prevent duplicate retrying? HOT 5
- FailsafeExecutor.compose and .with(Executor) have surprising composition behavior
- Provide BOM with all failsafe artifacts for better dependency management
- Failsafe okhttp integration causes issues with BearerAuth and outdated tokens
- CircuitBreakerBuilder withSuccessThreshold documentation whoopsy HOT 1
- [Question] Is it possible to override the "maxRetries" and "delay" of retry policy at runtime? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from failsafe.