Make RetryPolicy non final

[failsafe-lib]

Make RetryPolicy non final

[jhalterman]

It's a good practice to mark classes as final unless they're specifically designed with inheritance in mind. In this case, I don't see a problem, though I do have to ask, why not just create an instance of RetryPolicy that handles the exceptions you want and copy it if needed?

RetryPolicy basePolicy = new RetryPolicy().retryOn(apacheHttpExceptions);

public RetryPolicy newPolicy() {
  return basePolicy.copy();
}

[MALPI]

Because I want to use it in other Classes as well and with inheritance it is Mord convenient.

Besides that I'd like to give Circuitbreakers additional properties in Order to be able to identify them for monitoring reasons.

[jhalterman]

@MALPI Fair enough. Done!

I've been asked about having a CircuitBreaker registry or some sort of named tracking for CircuitBreakers, but for now I think that's best left to users to track circuit breakers however they want, via a Map or DI framework or whatever works best for them. And rather than adding a name to circuit breakers, that's how I would do it - by tracking them externally:

class CircuitBreakerRegistry {
  ConcurrentMap<String, CircuitBreaker> breakers = new ConcurrentHashMap<>();

  public CircuitBreaker breakerFor(String name) {
    return breakers.computeIfAbsent(key, k -> new CircuitBreaker().....);
  }
}

But whatever works for you!

[MALPI]

Thanks a lot for your Quick response and your input! Really like failsafe so far!

[jhalterman]

@MALPI Thanks. If you like it, please spread the word :)

[MALPI]

Did so ;-) See twitter... will promoted it also in the company. ;-)

[MALPI]

Can you release a new version for that?

[jhalterman]

I have some other changes waiting to go in before a release, but hopefully after this weekend.

[jhalterman]

Released