Comments (8)
I'm not an OSGi user, but I'd be happy to take a pull request for this so I don't mess it up :)
from failsafe.
@eurotrip11 Have a look at the commit I just pushed and let me know how that looks. Here's the branch
https://github.com/jhalterman/failsafe/tree/osgi
from failsafe.
Sorry for delay :)
I show the commit, is ok, but the better solution is add this configuration on maven plugin
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>3.0.1</version>
<extensions>true</extensions>
<executions>
<execution>
<id>bundle-manifest</id>
<phase>process-classes</phase>
<goals>
<goal>manifest</goal>
</goals>
</execution>
</executions>
<configuration>
<supportedProjectTypes>
<supportedProjectType>jar</supportedProjectType>
<supportedProjectType>bundle</supportedProjectType>
</supportedProjectTypes>
<instructions>
<Implementation-Title>${project.description}</Implementation-Title>
<Implementation-Version>${project.version}</Implementation-Version>
<Bundle-Name>Failsafe</Bundle-Name>
<Bundle-SymbolicName>net.jodah.failsafe</Bundle-SymbolicName>
<Export-Package>net.jodah.failsafe*;version=1.0</Export-Package>
<Import-Package>*</Import-Package>
</instructions>
</configuration>
</plugin>
and remove this tag on pom.xml <packaging>bundle</packaging>
so no need to manage ad hoc branch for osgi.
Thanks Giuseppe
from failsafe.
@eurotrip11 So I noticed that when removing the <packaging>bundle</packaging>
and doing a mvn build
, the generated MANIFEST.MF
inside my jar does not contain any package export information. It simply contains:
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Built-By: jonathan
Created-By: Apache Maven 3.1.1
Build-Jdk: 1.8.0_60
Does that seem right?
from failsafe.
@jhalterman Sorry :( i forgot this configuration :)
<plugin>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
</archive>
</configuration>
</plugin>
from failsafe.
No worries. What's the benefit of this approach over <packaging>bundle</packaging>
, which has been suggested in other projects?
from failsafe.
Greater support for the solutions not OSGi and not having to handle more than one branch for development. The solutions are identical to OSGi level does not change anything .
from failsafe.
Thanks for the help on this @eurotrip11.
from failsafe.
Related Issues (20)
- Why does CheckedPredicate exist? HOT 2
- Also add note about default maxRetries of 3 to maxDuration section of the documentation HOT 7
- Bulkhead policy may drop requests when maxWaitTime is specified HOT 8
- Guidance around CheckedPredicate HOT 2
- Time based error limiter policy
- [Question]Can withBackoff and withDelay be used at the same time? HOT 2
- RetryPolicy handleIf not working with DynamoDbException in predicate HOT 4
- Having a context object in the run(...) and get(...) methods HOT 7
- dev.failsafe.Functions.* do not propagate toString to the wrapped object
- [Question] Is it possible to have multiple Fallback policies in one Failsafe executor? HOT 4
- [question] how to use failsafe with kotlin
- Feature Request: Integrate / add support for Lunar Proxy (backend policy) HOT 1
- Why recommend CircuitBreaker before Retry? HOT 1
- CircuitBreaker stays in OPEN even after DELAY time HOT 1
- Nested retries, how to prevent duplicate retrying? HOT 5
- FailsafeExecutor.compose and .with(Executor) have surprising composition behavior
- Provide BOM with all failsafe artifacts for better dependency management
- Failsafe okhttp integration causes issues with BearerAuth and outdated tokens
- CircuitBreakerBuilder withSuccessThreshold documentation whoopsy HOT 1
- [Question] Is it possible to override the "maxRetries" and "delay" of retry policy at runtime? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from failsafe.