Giter Site home page Giter Site logo

Comments (4)

jhalterman avatar jhalterman commented on August 19, 2024

I'm fine with option 1 for a few reasons:

  • It keeps the tests simple and easy to read, so someone browsing the code can easily understand what the test is trying to do.
  • It's similar to what we're doing in various other tests (for better or worse, right now).

I'm open to improving things more substantially throughout the test suite, but readability/simplicity of the tests is somewhat important.

from failsafe.

leozilla avatar leozilla commented on August 19, 2024

I am also fine with option 1. Just wanted to point out some possibilities.
A PR follows in the upcoming days.

from failsafe.

jhalterman avatar jhalterman commented on August 19, 2024

Cool, thanks.

from failsafe.

jhalterman avatar jhalterman commented on August 19, 2024

@leozilla I just went ahead and did this since I hadn't heard back from you :)

from failsafe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.