Giter Site home page Giter Site logo

Comments (24)

patrik-hagne avatar patrik-hagne commented on June 14, 2024

The existing page was created by using an existing page and taking the first page from the wiki. Of course I have no objections to improve it what so ever. I'm not - as you put it - attached to the current layout at all!

I agree with all your points, the ladies picture was made for an advertisement on Stackoverflow and was never meant to be an icon so, an icon would be great.

I'm not sure that a domain name adds any real value and I have no personal interest in it but I wouldn't object either.

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Thanks, @patrik-hagne. The only benefit I see in a domain name is that it could be handy if ever FakeItEasy breaks up with GitHub. Until then, mentioning fakeiteasy.github.io a few times should cause the search engines to push people to the right place. Still, if anyone has interest, I'm still happy to pony up the $s for a couple of years.

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

I'm not too bothered about the domain name either. I think a split from
GitHub is very unlikely. Regarding a logo, I can ask my girlfriend to put
together some ideas. She did the logos for xBehave and LiteGuard. No
obligations in either direction.
On 18 Aug 2013 20:05, "Blair Conrad" [email protected] wrote:

Thanks, @patrik-hagne https://github.com/patrik-hagne. The only benefit
I see in a domain name is that it could be handy if ever FakeItEasy breaks
up with GitHub. Until then, mentioning fakeiteasy.github.io a few times
should cause the search engines to push people to the right place. Still,
if anyone has interest, I'm still happy to pony up the $s for a couple of
years.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-22836786
.

from fakeiteasy.github.io.

patrik-hagne avatar patrik-hagne commented on June 14, 2024

@adamralph It would be great if she could come up with a cool logo!

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Hear, hear!

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

I spun off #5 to track the logo issue. I'll work on the rest of the stuff I complained about here (except the domain name - that went over like a lead balloon) and submit something for everyone's eyeballs.

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Hi, @FakeItEasy/owners. I threw a mockup on my personal GitHub page so I wouldn't have to pollute this project with too many silly commits. If you have a moment, check it out and complain!

from fakeiteasy.github.io.

philippdolder avatar philippdolder commented on June 14, 2024

looks good to me for a start

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Thanks, @philippdolder. I just took a peek from work, and I'm troubled. I'm not getting the layout I want. From home (I think) and when I clone blairconrad.github.io and run jekyll locally, I get a page that looks like this:

image

But on the live site from work I'm seeing this:

image

But our proxy is weird. Are you getting the intended (more columny) layout?

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

Would it help to introduce twitter bootstrap? It includes a CSS reset which
increases the chances of everything looking the same cross browser and
cross OS.

On Thu, Aug 22, 2013 at 1:44 PM, Blair Conrad [email protected]:

Thanks, @philippdolder https://github.com/philippdolder. I just took a
peek from work, and I'm troubled. I'm not getting the layout I want. From
home (I think) and when I clone blairconrad.github.io and run jekyll
locally, I get a page that looks like this:

[image: image]https://f.cloud.github.com/assets/3275797/1008564/3ca02c84-0b28-11e3-8d5c-9009e7549d35.png

But on the live site from work I'm seeing this:

[image: image]https://f.cloud.github.com/assets/3275797/1008578/834e325c-0b28-11e3-8664-b559c5182546.png

But our proxy is weird. Are you getting the intended (more columny) layout?


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-23087107
.

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

My understanding is that Pure is supposed to be doing the same thing.
I'm not married to the framework. If you like Bootstrap, I can swap that in.

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

Ah, I see. I haven't used Pure before but it sounds fine. I suspect that
your proxy isn't letting something through, how does it react to a request
for http://yui.yahooapis.com/pure/0.2.1/pure-min.css ? or perhaps it's
another resource that that css is pulling in.

On Thu, Aug 22, 2013 at 2:02 PM, Blair Conrad [email protected]:

My understanding is that Pure http://purecss.io/ is supposed to be
doing the same thing.
I'm not married to the framework. If you like Bootstrap, I can swap that
in.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-23088067
.

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

I like the layout of the site. One observation - it seems more natural for the logo to be right aligned, otherwise it's kind of floating in no man's land. E.g.

screen shot 2013-08-22 at 14 21 14

As you can see I hacked this in by adding style="text-align: right;" to the column div and I wrapped the image in a div with class="box" in order to get the margins consistent. There's probably a more elegant way to do it.

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

Btw - obviously I do indeed see the site as intended, with columns. This is in OSX 10.7.5 Chrome 28.0.1500.95. @blairconrad which browser and OS versions are you using?

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Regarding my weird layout issue, I've noticed that if I go to the URL "fresh", it renders fine. As soon as I refresh it gets all wonky. Not so when I run local though. I can refresh that puppy all day long.

I'm using Portable Chrome Version 28.0.1500.95 on Windows 7 Enterprise - 6.1.7601 SP1 Build 7601.

As far as the right-aligned logo goes, you're absolutely right

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Oh, yeah, and I appear to be able to see all the .css and .js files from inside my proxy.

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Okay. Right-aligned.

And I can refresh in IE all the time with no ill effects. It must be my Portable Chrome.

from fakeiteasy.github.io.

philippdolder avatar philippdolder commented on June 14, 2024

@blairconrad I see the site as intended (Chrome Version 29.0.1547.57 m, on Windows 8)

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Okay. I think my problems seeing the page are just that - my problems.
I've updated the logo float (even since I implemented @adamralph's suggestion). As a bonus, I put the YouTrack/TeamCity banner at the bottom for #3. I thought the wide one looked nicer than the squareish one.

Are we all of the opinion that the page a "good enough for a start"? If so, I'll move to the fakeiteasy.github.io repo and submit a pull. Then more specific issues can be raised to improve it later?

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

I think it's good a start. Although when I browse to it now the fonts seem to have changed. The main body text now seems to be in a serif font for some reason. One other small point - the box containing the code needs some left padding. The text is flush with the edge of the box on that side only.

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

Ah. The fonts were intentional. I should've mentioned. I can revert the main body font to sans- serif. Do you dislike the header font as well?
And I'll pad the code box. I didn't notice the unevenness.

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

Ah ok, well I'm no expert but I ran it past my girlfriend who is a creative and she gave the fonts the thumbs up ;-)

from fakeiteasy.github.io.

blairconrad avatar blairconrad commented on June 14, 2024

The code box has a little left-padding now. Fun fact - there's none on the right, but it seems the renderer (for Chrome at least) likes to put a little whitespace on the right when wrapping.

Just to make sure our lines aren't crossed, your girlfriend gave the new fonts the thumbs up, or the old ones?

I'm not an expert either, but had heard things about mixing serifs and sans-serifs from time to time. And recently seen an article about 10 good Google font cominations. One had Ubuntu (the one currently used for the headers) and something else that I wasn't so sure about, but a serif. So, knowing that Georgia is a perennial favourite, and made for easy web reading, I gave it a go. I didn't think it looked so bad…

I'd've considered a serif for the headers, but thought maybe something that didn't look completely different from the FakeItEasy in the Two Ladies Talking pic…

Again, I'm not an expert, and not particularly invested. If you want a change you'll get one!

from fakeiteasy.github.io.

adamralph avatar adamralph commented on June 14, 2024

Yeah it was the new fonts that got the thumbs up. I think it's good to go.
I'd leave the headings sans serif for now. Great work!
On 24 Aug 2013 21:25, "Blair Conrad" [email protected] wrote:

The code box has a little left-padding now. Fun fact - there's none on the
right, but it seems the renderer (for Chrome at least) likes to put a
little whitespace on the right when wrapping.

Just to make sure our lines aren't crossed, your girlfriend gave the new
fonts the thumbs up, or the old ones?

I'm not an expert either, but had heard things about mixing serifs and
sans-serifs from time to time. And recently seen an article about 10 good
Google font cominations. One had Ubuntu (the one currently used for the
headers) and something else that I wasn't so sure about, but a serif. So,
knowing that Georgia is a perennial favourite, and made for easy web
reading, I gave it a go. I didn't think it looked so bad…

I'd've considered a serif for the headers, but thought maybe something
that didn't look completely different from the FakeItEasy in the Two Ladies
Talking pic…

Again, I'm not an expert, and not particularly invested. If you want a
change you'll get one!


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-23215895
.

from fakeiteasy.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.