Giter Site home page Giter Site logo

Comments (9)

matthewmayer avatar matthewmayer commented on June 4, 2024 1
  1. Yes
  2. Yes

🤣

Will open a new PR

from faker.

xDivisionByZerox avatar xDivisionByZerox commented on June 4, 2024 1
  1. were you just used to the previous colors?

To prevent personal oppinion, we should maybe define a design spec for Faker's "branding". I'll add the point to the next meetings discussion list.

from faker.

Shinigami92 avatar Shinigami92 commented on June 4, 2024

It's just a redesign of Vitepress (we are mostly using the default theme)
Only the "Browse API" Button is slightly customized by us
Might need to use the text-color of the border like before

from faker.

Shinigami92 avatar Shinigami92 commented on June 4, 2024

AHA! the issue is that I only designed the button in dark mode, not respecting light mode at all 😆
will fix it

from faker.

matthewmayer avatar matthewmayer commented on June 4, 2024

sorry added in wrong repo, moved here

from faker.

matthewmayer avatar matthewmayer commented on June 4, 2024

i thought the green looked nicer :)

looks like you can easily override the main theme colors by overriding some CSS vars, if we want the green back (or another color)

image

from faker.

Shinigami92 avatar Shinigami92 commented on June 4, 2024

If you like to change the color and want to customize the default style, pls open another PR

I just fixed the brand button's text in light mode

from faker.

Shinigami92 avatar Shinigami92 commented on June 4, 2024

@matthewmayer also ask yourself 2 questions 🙂

  1. were you just used to the previous colors?
  2. is it worth for you to maintain override of Vitepress design 🙃

But I wont hold you back 🚀

from faker.

matthewmayer avatar matthewmayer commented on June 4, 2024

could use the reds from the stripe of the hat perhaps

image

from faker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.