Giter Site home page Giter Site logo

Generate Planet names about faker HOT 9 OPEN

matthewmayer avatar matthewmayer commented on June 11, 2024 4
Generate Planet names

from faker.

Comments (9)

matthewmayer avatar matthewmayer commented on June 11, 2024 2

Pluto is not a planet 😀

from faker.

ST-DDT avatar ST-DDT commented on June 11, 2024 2

Currently, I think space is the best match, followed by location and then science.
From science.planet I would except the numbered planet notation.

from faker.

ST-DDT avatar ST-DDT commented on June 11, 2024 1

Do you want exactly those well known planet names or any planet names?

from faker.

matthewmayer avatar matthewmayer commented on June 11, 2024 1

Just the major planets

from faker.

matthewmayer avatar matthewmayer commented on June 11, 2024 1

For comparison Faker-Ruby has a few space methods. Their "planet" method is "planet (in our solar System)"
https://github.com/faker-ruby/faker/blob/main/doc/default/space.md

from faker.

ST-DDT avatar ST-DDT commented on June 11, 2024 1

Nothing we have to decide now, lets wait on more input/upvotes.

from faker.

github-actions avatar github-actions commented on June 11, 2024

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

from faker.

Shinigami92 avatar Shinigami92 commented on June 11, 2024

Do you want exactly those well known planet names or any planet names?

This was exactly my first thought. Even if we dont want scientific planets now, we might want to consider a method name that does not get in conflict if we want to generate names like KMT-2021-BLG-1150L b

from faker.

xDivisionByZerox avatar xDivisionByZerox commented on June 11, 2024

Currently, I think space is the best match, followed by location and then science.
From science.planet I would except the numbered planet notation.

I understand your reasoning, but I'm not a big fan of introducing new modules at the current moment. We still have some places where we are not sure whether a function would be better located in module X or Y. Adding more modules makes this problem potentially worse until we have clear definitions about the "Module" term, or we introduce an easy way to reference aliases.

That being said, I would not expect planet to be located under the LocationModule as this has more of an "on earth locations"-vibe to me.
Science sounds reasonable to me. But again, @ST-DDT made a good point with the "numbered planet notations".


Another thing I want to point out is the method faker.person.zodiacSign. While not directly related, they could end out being on the same meta level. I just want this to be considered. Not putting "planet" into the PersonModule, but the fact of potential relation in general.

from faker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.