Giter Site home page Giter Site logo

Comments (8)

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jdreichmann on Aug 30, 2022, 08:56

Would veto, mark as unmaintained instead?

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Aug 30, 2022, 12:48

added 2 commits

  • 7ce8425 - 1 commit from branch main
  • 3118efd1 - chore: deprovision zammad

Compare with previous version

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Feb 1, 2023, 13:13

I veto your veto:

❯ ansible-lint playbooks/zammad.yml roles/zammad
WARNING  Listing 27 violation(s) that are fatal
name[play]: All plays should be named. (warning)
playbooks/zammad.yml:2

yaml[brackets]: Too many spaces inside brackets
playbooks/zammad.yml:2

yaml[truthy]: Truthy value should be one of [false, true]
roles/zammad/defaults/main.yml:6

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_container`. (warning)
roles/zammad/handlers/main.yml:1 Action `docker_container` is not FQCN.

yaml[truthy]: Truthy value should be one of [false, true]
roles/zammad/handlers/main.yml:5

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_container`. (warning)
roles/zammad/handlers/main.yml:7 Action `docker_container` is not FQCN.

yaml[truthy]: Truthy value should be one of [false, true]
roles/zammad/handlers/main.yml:11

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_container`. (warning)
roles/zammad/handlers/main.yml:13 Action `docker_container` is not FQCN.

yaml[truthy]: Truthy value should be one of [false, true]
roles/zammad/handlers/main.yml:17

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_container`. (warning)
roles/zammad/handlers/main.yml:22 Action `docker_container` is not FQCN.

fqcn[action-core]: Use FQCN for builtin module actions (user).
roles/zammad/tasks/main.yml:2 Use `ansible.builtin.user` or `ansible.legacy.user` instead.

yaml[truthy]: Truthy value should be one of [false, true]
roles/zammad/tasks/main.yml:6

fqcn[action-core]: Use FQCN for builtin module actions (file).
roles/zammad/tasks/main.yml:10 Use `ansible.builtin.file` or `ansible.legacy.file` instead.

yaml[brackets]: Too many spaces inside brackets
roles/zammad/tasks/main.yml:17

fqcn[action-core]: Use FQCN for builtin module actions (file).
roles/zammad/tasks/main.yml:20 Use `ansible.builtin.file` or `ansible.legacy.file` instead.

yaml[brackets]: Too many spaces inside brackets
roles/zammad/tasks/main.yml:27

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/zammad/tasks/main.yml:31 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

yaml[brackets]: Too many spaces inside brackets
roles/zammad/tasks/main.yml:38

fqcn[action-core]: Use FQCN for builtin module actions (template).
roles/zammad/tasks/main.yml:42 Use `ansible.builtin.template` or `ansible.legacy.template` instead.

yaml[brackets]: Too many spaces inside brackets
roles/zammad/tasks/main.yml:49

fqcn[action-core]: Use FQCN for builtin module actions (template).
roles/zammad/tasks/main.yml:52 Use `ansible.builtin.template` or `ansible.legacy.template` instead.

fqcn[action-core]: Use FQCN for builtin module actions (template).
roles/zammad/tasks/main.yml:62 Use `ansible.builtin.template` or `ansible.legacy.template` instead.

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_image`. (warning)
roles/zammad/tasks/main.yml:72 Action `docker_image` is not FQCN.

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_network`. (warning)
roles/zammad/tasks/main.yml:84 Action `docker_network` is not FQCN.

args[module]: unable to evaluate string as dictionary (warning)
roles/zammad/tasks/main.yml:90 Task/Handler: Ensure zammad containers are started

fqcn[action]: Use FQCN for module actions, such `community.docker.docker_container`. (warning)
roles/zammad/tasks/main.yml:90 Action `docker_container` is not FQCN.

yaml[line-length]: Line too long (191 > 160 characters)
roles/zammad/tasks/main.yml:99

You can skip specific rules or tags by adding them to your configuration file:
# .config/ansible-lint.yml
warn_list:  # or 'skip_list' to silence them completely
  - experimental  # all rules tagged as experimental
  - fqcn[action-core]  # Use FQCN for builtin actions.
  - yaml[brackets]  # Violations reported by yamllint.
  - yaml[line-length]  # Violations reported by yamllint.
  - yaml[truthy]  # Violations reported by yamllint.

                      Rule Violation Summary                       
 count tag               profile    rule associated tags           
     1 name[play]        basic      idiom (warning)                
     5 yaml[brackets]    basic      formatting, yaml               
     1 yaml[line-length] basic      formatting, yaml               
     5 yaml[truthy]      basic      formatting, yaml               
     7 fqcn[action-core] production formatting                     
     7 fqcn[action]      production formatting (warning)           
     1 args[module]                 syntax, experimental (warning) 

Failed after min profile: 18 failure(s), 9 warning(s) on 12 files.

I don't think it's worth our time to fix these lints here, and if someone wants the role and playbook, they can salvage it from the git history. Alternatively, we could have a famedly.toiletwater collection where we dispose of unmaintained stuff, but keeping unmaintained stuff around in our regular collections feels wrong because they hurt our linting rules.

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Feb 1, 2023, 16:03

added 9 commits

  • 3118efd1...d9201cac - 7 commits from branch main
  • eca40dad - chore: deprovision zammad
  • 06f95fa4 - tmp, don't merge

Compare with previous version

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Feb 1, 2023, 16:06

added 1 commit

  • b39ffaa9 - tmp, don't merge

Compare with previous version

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Feb 24, 2023, 13:35

added 1 commit

  • 5e0f25ba - chore: deprovision zammad

Compare with previous version

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @jcgruenhage on Feb 24, 2023, 13:41

added 1 commit

  • 0ff44e4 - chore: deprovision zammad

Compare with previous version

from ansible-collection-services.

famedly-bot avatar famedly-bot commented on August 16, 2024

In GitLab by @lrsksr on Feb 24, 2023, 13:49

approved this merge request

from ansible-collection-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.