farsightsec/axa

The Advanced Exchange Access suite

axa's Issues

3rd party libedit/editline --> incorrectly displays unicode chars

Summary: sratool shows incorrectly represented Unicode/wide characters when built with
external libedit/editline

Details: Some systems need a 3rd party libedit/editline library to build axa. This would
normally come from http://thrysoee.dk/editline/

Note the lined out comment there:

"Unicode
To build libedit with support for unicode (wide-char/UTF-8), add
the --enable-widec option when running configure,

./configure --enable-widec"

That lined out text was replaced with:

"Always builds with unicode (wide-char/UTF-8) support now."

Reproduce Issue: Once axa is built from sources and installed with the
quoted libedit/editline library, start sratool, type a random non-command
and hit return:

sratool
sra> asdasdasdasasdadsd
unrecognized command "asdasdasdasasdadsd"
?
sra> \U+C473\U+C461\U+C464\U+C461\U+C473\U+C464

Note unrendered wide characters.

Jeremy noted in email:

-- quote --
Maybe because the code uses char but when using wide char it should be
wchar_t.

I see some other projects like asterisk and LLDB had same problem with
the editline upgrade, for example:
asterisk/asterisk@72da2ef
http://llvm.org/viewvc/llvm-project?revision=303907&view=revision
I can look at reproducing this and provide a ifdef for this in axa
(maybe in sratool/cmd.c). [...]

(By the way, the change came from NetBSD.)
-- quote --

Thanks,

Joe

Audit axa / axa-tools installation instructions

help_cmd should run for first argument only and too many arguments or wrong argument should say that

Instrumented sratool/cmd.c so I can see arg:

$ echo debug quidt | ./sratool/sratool
No matching help topic could be found for debug quidt
 ?

That was a typo on purpose which returns unhelpful: "No matching help topic could be found" (which doesn't say 'for ...".

This same "No matching help topic could be found" happens when having too many arguments or wrong argument.

Another example:
$ echo help help "?" | ./sratool/sratool
No matching help topic could be found

When used for "help" it is not as confusing. It is confusing when the error says "help" but you didn't use "help"

Consider having help_cmd() only check for first argument?

miscellaneous radtool non-server tests

I am writing several radtool tests for the command-line tool that don't use a server.

Just opening this ticket for tracking first round of work on this.

unrecognized command "tag"

help output shows:

 tag watch {ip=IP[/n] | dns=[*.]dom | ch=chN | errors}

But using tag or tag watch results in "unrecognized command" and help tag results in "No matching help topic could be found"