Ability to Add custom view above, below and on sides of focused view

[rr-akshay-dave]

Ability to Add custom view above, below and on sides of focused view

[faruktoptas]

Please check this example:

FancyShowCaseView/app/src/main/java/me/toptas/fancyshowcasesample/MainActivity.kt

Line 257 in efe261a

image.post {

[rr-akshay-dave]

@faruktoptas Thanks. I checked it out.
That sample works if a focus view is not dynamic (e.g regular view vs list item view). For focus view that is dynamic the calculations don't always work.

[faruktoptas]

Calculations are done when build() method is called with a view. If you build your FancyShowCaseView instance after inflation of target view it should work.

[rr-akshay-dave]

@faruktoptas Thanks for taking time to respond. I am doing calculations in the .customView() method during the build time like below

    .customView(R.layout.my_custom_view, object : OnViewInflateListener {
                override fun onViewInflated(view: View) {
                    val params = view.layoutParams as FrameLayout.LayoutParams
                    view.post {
                       // This works
                        params.leftMargin = fancyShowCaseView.focusCenterX - view.width / 2
                        view.layoutParams = params
                    }

                   // some code for init
                     ...
                      ...


                    // Get the layout param of top level view group of custom view
                    val customView = (view as LinearLayout).findViewById<LinearLayout>(R.id.customView)
                    val customViewParamParams = customView.layoutParams as FrameLayout.LayoutParams
                    
                    // Adjust the top margin for custom view so that it's on top of focused view.
                    // This calculation is guesstimate, and DOESN'T WORK when the focused view's height changes dynamically
                    customViewParams.topMargin =
                        fancyShowCaseView.focusCenterY - fancyShowCaseViewView.focusHeight - focusedView.measuredHeight / 2
                    customView.layoutParams = customViewParams
                }
            })

Let me know if you see something wrong.

[faruktoptas]

Can you share a screenshot to see more details about buggy behaviour.

[rr-akshay-dave]

Sure. Device Pixel 3 A (but it's same behavior on any other Pixel emulators)

Context Use case 1 :

• I created list view with 4 textviews in each list item. I am highlighting item # 5 in the list
• I am showing all 4 text views in this case. Notice how custom view is nicely on top
• Screen shot 1:
  

Context Use case 2 :

• I am showing only 2 text views out of 4 text views in this case. Notice how custom view is off
• Screen shot 2:
  

[rr-akshay-dave]

Btw, I appreciate you taking time to respond. I am happy to DM you on twitter or something to save time for both if that works for you.

[rr-akshay-dave]

Hello @faruktoptas , just following up. Let me know if you need anything else on this from my end.

[DevHisham]

i faced same issue

[faruktoptas]

@rr-akshay-dave @DevHisham
My apologies for the delayed response. If this is an active issue for you please let me know.