Giter Site home page Giter Site logo

Comments (4)

pjfanning avatar pjfanning commented on July 19, 2024 1

It's not that we use the methods. The build checks for API changes and when we subclass, the build will fail if methods are removed in the super classes. These checks can be configured to ignore certain diffs and I've now done that.

from jackson-module-scala.

pjfanning avatar pjfanning commented on July 19, 2024

I fixed the build issue with ae65569

from jackson-module-scala.

cowtowncoder avatar cowtowncoder commented on July 19, 2024

@pjfanning Ok sorry about that. I had assumed that all modules would have long ago switched not to use those methods -- and also rebuilt core modules. But I forgot that I do not do this for Scala module.

And I should also know better than to start cleanup after second release candidate. In future I will postpone these appropriately.

Thank you for catching this so quickly.

from jackson-module-scala.

cowtowncoder avatar cowtowncoder commented on July 19, 2024

Ok good. Kotlin module does something similar, makes sense.

Might make sense for databind too, although one concern I have is with sheer number of overrides needed for "internal" changes (in theory any change to any protected methods is backwards-incompatible change). The idea is valid tho, it is important to be aware of such changes to avoid accidental removal/change of methods.

from jackson-module-scala.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.