ctx.userValues is shared across different request matches causing unpredictable results?

[fasthttp]

ctx.userValues is shared across different request matches causing unpredictable results?

[savsgio]

Fixed 😉

Thanks for your issue!

[savsgio]

Hi @gsych,

Sorry for remove my answer, but i think the better solution it's save a copy directly to the user values and avoid confusions in a future.

I will upload the fix now.

[gsych]

Superb!

[sashayakovtseva]

Added a PR with tests: #52.
@savsgio Pls take a look.

[gsych]

Hi @savsgio !

Thank you for your reply. Yes, it was clear why this happens from the beginning. Still, I think there should be a note about that in the documentation or a comment to the UserValue func or anywhere else, otherwise in my opinion it's really misleading. I've spent several hours trying to figure out why the hell I have a data corruption and never had a second thought that I actually have to allocate a new copy. Having a proper allocation in the UserValue usage example would definitely prevent this.

Thank you for your effort!

[sashayakovtseva]

Hello @savsgio,

Looks like this issue still exists for regex params. Here no copy of path is made, so it is possible to have values corrupted.