Giter Site home page Giter Site logo

Comments (5)

delvedor avatar delvedor commented on May 20, 2024 1

It definitely depends on your code, for example, you have a web service that needs mongodb, without it cannot work.
What you do is try to connect to mongo with this plugin and if you can't, throw an error.

Don't forget that the callback is executed at bootstrap time, so if it have to crash, it will do it when you open up the server, not at "runtime" :)

from fastify-mongodb.

XVincentX avatar XVincentX commented on May 20, 2024 1

I disagree but ok, I got your point.

from fastify-mongodb.

delvedor avatar delvedor commented on May 20, 2024

Throw in that callback will crash your process :)
The error handling is demanded to the user, it is your choice how handle it.

from fastify-mongodb.

XVincentX avatar XVincentX commented on May 20, 2024

The error handling is demanded to the user, it is your choice how handle it.

I know, I was just thinking that's is wrong to put it there; a good console.error in case of any error would probably be better, but it's your call.

from fastify-mongodb.

mcollina avatar mcollina commented on May 20, 2024

The correct approach is not to place any callback there. The default behavior in case of error is well defined (it will emit an 'error' event on the server). We just need to update the README.

Placing console.error(err) there are wrong in both cases, as those are fatal and not-recoverable errors for the demo script.

from fastify-mongodb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.