Comments (5)
It definitely depends on your code, for example, you have a web service that needs mongodb, without it cannot work.
What you do is try to connect to mongo with this plugin and if you can't, throw an error.
Don't forget that the callback is executed at bootstrap time, so if it have to crash, it will do it when you open up the server, not at "runtime" :)
from fastify-mongodb.
I disagree but ok, I got your point.
from fastify-mongodb.
Throw in that callback will crash your process :)
The error handling is demanded to the user, it is your choice how handle it.
from fastify-mongodb.
The error handling is demanded to the user, it is your choice how handle it.
I know, I was just thinking that's is wrong to put it there; a good console.error
in case of any error would probably be better, but it's your call.
from fastify-mongodb.
The correct approach is not to place any callback there. The default behavior in case of error is well defined (it will emit an 'error'
event on the server). We just need to update the README.
Placing console.error(err)
there are wrong in both cases, as those are fatal and not-recoverable errors for the demo script.
from fastify-mongodb.
Related Issues (20)
- fastify-mongodb is "eating" errors on register HOT 1
- this: Object is possibly 'undefined HOT 1
- TypeScript Example needed HOT 1
- Mongodb connection error HOT 19
- Fastify get route requires options? HOT 2
- Typescript: object is possibly undefined HOT 5
- Database Selection At Runtime HOT 4
- find() method returns events HOT 2
- Connection failes using Scalegrid.io HOT 5
- [email protected] is incompatible with newer version of [email protected]. HOT 2
- GCP Deploy using @fastify/mongodb HOT 3
- Mongodb find({}) error HOT 5
- Enable Dependabot HOT 7
- Consider re-exporting some (all?) types from mongodb HOT 1
- Update MongoDB v5 HOT 1
- Move MongoDB to peerDependencies HOT 14
- Pass variable to regex fails HOT 4
- Error Plugin did not start in time: '@fastify/mongodb'. You may have forgotten to call 'done' function or to resolve a Promise HOT 19
- onClose hook blocking main process HOT 7
- fastify.mongo.client.topology // TS2339: Property topology does not exist on type MongoClient HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastify-mongodb.