Giter Site home page Giter Site logo

Comments (9)

gurgunday avatar gurgunday commented on June 7, 2024 3

Thank you so much for the PR!

from fastify-rate-limit.

tobiasdcl avatar tobiasdcl commented on June 7, 2024 3

@tobiasdcl 9.0.1 with the fix was released! thank you for the report and the PR

Awesome, thank you for the super fast fix 🥳

from fastify-rate-limit.

Uzlopak avatar Uzlopak commented on June 7, 2024 2

Nice job!

from fastify-rate-limit.

kibertoad avatar kibertoad commented on June 7, 2024 2

@tobiasdcl 9.0.1 with the fix was released! thank you for the report and the PR

from fastify-rate-limit.

Uzlopak avatar Uzlopak commented on June 7, 2024

@gurgunday
@kibertoad

from fastify-rate-limit.

tobiasdcl avatar tobiasdcl commented on June 7, 2024

I can submit a PR but would like some guidance about the approach. Given that the issue is in an underlying library (if my understanding is correct) I am not sure if you want to revert to the prev. LRU cache or wait for a fix in toad-cache

from fastify-rate-limit.

tobiasdcl avatar tobiasdcl commented on June 7, 2024

Here are also some more details. The problem is that the lru.first is set to null if a value is first set and then retrieved via get

Bildschirmfoto 2023-11-29 um 18 39 29


Bildschirmfoto 2023-11-29 um 18 40 28

and once lru.first is set to null it is just a matter of time before reaching the cache limit causing the first evict call - from that point on it is game over 😅

from fastify-rate-limit.

Uzlopak avatar Uzlopak commented on June 7, 2024

probably has to be fixed in toad-cache and not here.

from fastify-rate-limit.

tobiasdcl avatar tobiasdcl commented on June 7, 2024

probably has to be fixed in toad-cache and not here.

I created a PR 🙌

from fastify-rate-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.