Giter Site home page Giter Site logo

Comments (6)

jsumners avatar jsumners commented on July 24, 2024 1

I'd be happy to create a PR, in fact I've already created a local branch with a commit, but don't have permissions to push.

See https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

from fastify-websocket.

jsumners avatar jsumners commented on July 24, 2024

It is not "pinned" --

"find-my-way": "^3.0.4",

https://docs.npmjs.com/cli/v6/using-npm/semver#caret-ranges-123-025-004

^3.0.4 indicates the minimum supported version.

from fastify-websocket.

tylercraft avatar tylercraft commented on July 24, 2024

Sorry, misread. That said, the ask is the same, that the version number gets bumped.

from fastify-websocket.

jsumners avatar jsumners commented on July 24, 2024

Sure, a PR to do it would be welcome. But I fail to understand how this is an issue since an install should cover it.

from fastify-websocket.

tylercraft avatar tylercraft commented on July 24, 2024

I'd be happy to create a PR, in fact I've already created a local branch with a commit, but don't have permissions to push.

Regarding being an issue, I wasn't sure the best way to submit it. The instructions weren't clear. It's not a feature. It's not a 'regression'. It's already a public vulnerability, so going down that path seemed overkill.

from fastify-websocket.

tylercraft avatar tylercraft commented on July 24, 2024

Thanks, closing this out as PR is created: #93

from fastify-websocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.