Supplying a logger removes the stream of the logger

[fastify]

Supplying a logger removes the stream of the logger

[jsumners]

ahem I'm one of those guys :)

I'd just check to see if the passed in option is a function and then pass it through to pino-http appropriately.

I'll submit a PR after work.

[delvedor]

The logger option purpose is not intended for setting a custom logger, but for pass some options to the internal pino-http instance.
Have a look here and here :)

[delvedor]

Probably you can try with:

const log = require('pino')()
const fastify = require('fastify')({
  logger: {
    logger: log
  }
})

pino-http options

[jsumners]

Then I think it should support passing in a custom logger. I didn't include it in the example, but I would further use req.log in request handlers. This means I only have to configure one logger to use it in both manners: regular logs and request logs.

[jsumners]

The {logger: {logger: log}} is ugly, but it works.

[delvedor]

Yeah, I agree.
I would like to ask to the 'pino guy' @mcollina: any idea on how design a nicer api?

[delvedor]

Ops! Sorry :P

Anyway, PR are welcome!

[mcollina]

thanks @jsumners!!

[delvedor]

#52