Comments (9)
At the moment target: any
means:
the action does not check the semver before approve&merge
Instead, target: *
could mean:
before approve&merge check if the semver has a right format
This is a different meaning for me.
A quick search about these GHA users let me think if all these repos rely on semver
.
I would rename any
to disabled
instead
from github-action-merge-dependabot.
again the main thing to consider here is supporting submodules which don't have a semver version as per #95
from github-action-merge-dependabot.
see also conversation in #121 for context
from github-action-merge-dependabot.
Right now target: any
means any target, so put in other words: the check is actually disabled, right?
The *
rename proposal was to align to the SemVer spec (as we state in the docs, target
needs to be a valid SemVer identifier), because it literally means any version.
However, given the submodule requirement (target
is a git hash, so not a valid SemVer neither), the right thing to do IMHO would be to just leave target undefined
by default, because it's an optional field and it doesn't really need to have a value, I think it would be easiest to understand in this way (no target by default, no check).
from github-action-merge-dependabot.
Well the change is already merged and released but this issue is still open because it wasn't linked from the PR
from github-action-merge-dependabot.
@nuragic can you please acknowledge the message above? If so, can you please close this issue?
from github-action-merge-dependabot.
I agree about that it doesn't make sense to use *
so I'll close it now.
But I'd like to address this proposal.
Given the submodule requirement (target is a git hash, so not a valid SemVer neither), the right thing to do IMHO would be to just leave target undefined by default, because it's an optional field and it doesn't really need to have a value, I think it would be easiest to understand in this way (no target by default, no check).
Maybe in a new issue?
from github-action-merge-dependabot.
Yes, thanks!
from github-action-merge-dependabot.
Moved to #128
from github-action-merge-dependabot.
Related Issues (20)
- Different targets for `development` and `production` dependencies HOT 3
- Release pending!
- Major version update is auto-merged with target set to minor HOT 16
- "Fetch metadata" step is skipped for "pull_request_target"
- Release pending!
- Clarify meaning of "target" option HOT 1
- Receiving 'Warning: Semver bump '' is invalid!' message HOT 3
- Fail with meaningful error in case an unsupported trigger is used HOT 1
- remove semver as dep HOT 1
- deprecation warning in test/log.test.js HOT 1
- use nearform-actions HOT 1
- remove gitdiff-parser as dependency HOT 1
- use esbuild instead of ncc
- Feature: Allow defining targets per pattern or group
- replace husky with @fastify/pre-commit
- use taprc and show coverage report HOT 1
- Suppress warning in CI/CD pipeline HOT 1
- remove @actions/github HOT 1
- Output does not seem to appear HOT 2
- Frequently see error "Pull request is in unstable status" (but all validation checks pass) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-action-merge-dependabot.