Comments (10)
@Eomm can you do a manual release of the action? We'll have to wait until next week before publishing this action using release automation, because the current version is not capable of auto updating if we create the non-semver tags
from github-action-merge-dependabot.
and it should also keep working with submodules. see #98
from github-action-merge-dependabot.
One approach is the one mentioned above by @Eomm; another approach would be to use the valid SemVer number, which is in this case 2.3.0
... would be that possible? It seems that we have that information in the pull requests opened by dependabot, e.g.
We're extracting the 2.3
from the title?
from github-action-merge-dependabot.
We're extracting the 2.3 from the title?
yes. I think the approach is to use coerce / loose options from the semver library
from github-action-merge-dependabot.
What I'm saying is that IMHO the right thing to do would be to have the valid SemVer number even in the title, e.g.
chore(deps): bump actions/setup-node from 2.4.1 to 2.5.0
nearform-actions/optic-release-automation-action#15
from github-action-merge-dependabot.
we can't, we're not creating those PRs, dependabot is
from github-action-merge-dependabot.
Yeah of course hehe I know but there's no way to fix that by changing some config here?
https://github.com/fastify/github-action-merge-dependabot/blob/main/.github/dependabot.yml
from github-action-merge-dependabot.
no
from github-action-merge-dependabot.
Yes, I have checked the main
dist folder and it is all aligned.
Publishing...
from github-action-merge-dependabot.
I'm having an issue where the action still merges a major release even if the target is set to minor.
For example, React v17.0.2 to v18.0.0 still gets merged.
automerge:
needs: analyze
runs-on: ubuntu-latest
permissions:
pull-requests: write
contents: write
if: ${{ github.event_name == 'pull_request' }}
steps:
- uses: fastify/github-action-merge-dependabot@v3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
target: minor
Example PR: austins/smoothnanners-web#17
from github-action-merge-dependabot.
Related Issues (20)
- Different targets for `development` and `production` dependencies HOT 3
- Release pending!
- Major version update is auto-merged with target set to minor HOT 16
- "Fetch metadata" step is skipped for "pull_request_target"
- Release pending!
- Clarify meaning of "target" option HOT 1
- Receiving 'Warning: Semver bump '' is invalid!' message HOT 3
- Fail with meaningful error in case an unsupported trigger is used HOT 1
- remove semver as dep HOT 1
- deprecation warning in test/log.test.js HOT 1
- use nearform-actions HOT 1
- remove gitdiff-parser as dependency HOT 1
- use esbuild instead of ncc
- Feature: Allow defining targets per pattern or group
- replace husky with @fastify/pre-commit
- use taprc and show coverage report HOT 1
- Suppress warning in CI/CD pipeline HOT 1
- remove @actions/github HOT 1
- Output does not seem to appear HOT 2
- Frequently see error "Pull request is in unstable status" (but all validation checks pass) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-action-merge-dependabot.