Prevent automerge failures

[fastify]

Prevent automerge failures

[ramonmulia]

@simoneb After after diving into the issue I wasn't able to reproduce it.

It could be a race condition but no reason to skip the build step Required status check "build" is in progress.

The pull_request event triggers when a PR event occurs targeting the branches specified in the workflow and
push event is triggered whenever a commit is pushed to the specified branches.

Since a PR merge is just a commit pushed to the target branch it will trigger push events,
I believe it could listen just push events instead of both (pull_request and push), as this action will get just dependabot PRs to process skipping those that aren't.

what do you think?

[simoneb]

Hi Ramon, I believe the solution is to simply restrict which push and pull_request events trigger the workflow.

Usually we want a CI workflow to run:

• on pull requests: whenever a PR is opened or new commits are pushed to it. I think this required the pull_request event
• on pushes to master: this requires the push event, but it can be restricted to only pushes to master

[ramonmulia]

Hey @simoneb, after some tests, I can point out the following scenarios:


on:
  

    pull_request:
        types: [opened, edited]
    push: 
	branches:
		- ‘master’

• It will trigger pull_request while creating a new PR, but if you commit something afterwards it will not dispatch the action again.
• The edited type is when you edit something into PR like description not when you commit something.

This way it will run only the first time you create the PR (and when you edit something into it) but NOT for new PR commits and also when it is merged to master.

on:
  push: 

It will work in all scenarios.

• When you create a new PR
• When you commit in the PR
• When merged to master or any branch

I mean, we don’t need to specify pull_request if we want this runs when the PR is opened, but we need to specify push for new commits