Comments (5)
So I cloned this lib, removed GraphicsMagick from my machine (with brew uninstall), and after some updating that rubocop suggested, I ran the actions and it did not crash, it created all images (I did have ImageMagick installed). Though I haven't compared the image output to the unaltered version (couldn't run it, as rubocop found some lines needed updating). @joshdholtz sorry to bother you, but I couldn't find why GraphicsMagick is a dependency and not ImageMagick, though the two are somewhat interchangeable.
from fastlane-plugin-appicon.
@ssilverr No worries about the ping! So...
GraphicsMagick
and ImageMagick
are not direct dependencies of this plugin. The direct dependency is the mini_magic
gem. mini_magick
is a wrapper around either GraphicsMagick
or ImageMagick
(which are standalone executables).
GraphicsMagick
is derived from ImageMagick
(possible a direct fork) but also slightly different in the features that it provides these days. It seems that mini_magick
offer a small enough feature set that it is interchangeable with either of the tools.
So... GraphicsMagick
isnβt a requirement but having either GraphicsMagick
or ImageMagick
is a requirement π
I hope this helps! β€οΈ
from fastlane-plugin-appicon.
@joshdholtz Wow, thanks for the quick reply!
Thank you, that's what I gathered as well. So I tested it again, and this time the action fails, if I don't have GraphicsMagick installed (don't know why i didn't fail before, maybe my machine needed a restart). It tries to call gm identify ...
but fails, as it can't find the gm executable. Now, if I configure MiniMagick in the action like:
MiniMagick.configure do |config|
config.cli = :imagemagick
config.timeout = 5
end
the actions run wihtout a hich. Two questions:
- If the deafult cli is ImageMagick, why is it trying to call
gm
? - Can I submit a PR, where you could set your default cli? Altough, I'm not sure if it would break existing setups, if the we define
GraphicsMagick
to be the deafult (then again, it shouldn't because this plugin explicitly requires it)
from fastlane-plugin-appicon.
@joshdholtz Well either way, here it is #67 (sorry the diffrerent user)
from fastlane-plugin-appicon.
Closing for #67
from fastlane-plugin-appicon.
Related Issues (20)
- Icons for new Apple Watch Series 4 HOT 3
- Is there any way to handle creation of LaunchImages?
- can not update fastlane because of mini_magick dependency HOT 2
- Error loading plugin 'fastlane-plugin-appicon' HOT 5
- add support for launch images
- Could not find option 'appicon_devices' in the list of available options
- Doesn't add 1024 x 1024 icon HOT 4
- Generate Rounded Error HOT 2
- not all images get created
- Add support for image url on source HOT 1
- Possibility to bypass 1024 as minimum width HOT 1
- Not working if there are spaces in the path too project root folder
- [Swift] undefined method 'each' for nil:NilClass HOT 1
- Adjust the size of image used for splash screen HOT 7
- iTMSTransporter requires App Store Icon to have no transparent or alpha channel HOT 1
- Could not find action, lane or variable 'appicon' HOT 1
- How to change timeout for the minimagic
- the generated macos app iconset is invalid
- appicon_name field ignored
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastlane-plugin-appicon.