Giter Site home page Giter Site logo

readme states it executes 'cordova build' but actually executes 'cordova prepare' and 'cordova compile' about fastlane-plugin-ionic HOT 5 CLOSED

josh-m-sharpe avatar josh-m-sharpe commented on May 2, 2024
readme states it executes 'cordova build' but actually executes 'cordova prepare' and 'cordova compile'

from fastlane-plugin-ionic.

Comments (5)

janpio avatar janpio commented on May 2, 2024

cordova build is just cordova prepare and then cordova compile stringed together: https://cordova.apache.org/docs/en/8.x/reference/cordova-cli/index.html#cordova-build-command

What you refer to, is probably taken care of by #31 (Correct?)

from fastlane-plugin-ionic.

josh-m-sharpe avatar josh-m-sharpe commented on May 2, 2024

Possibly. It seems that cordova prepare/compile don't respect options set in build.json... which does things other than just set buildFlags.

Why does this plugin use prepare and compile instead of just build?

from fastlane-plugin-ionic.

janpio avatar janpio commented on May 2, 2024
  1. Because the plugin this was forked off also did/does that ;)
  2. It enables you to not run prepare if you want more control about what is going on. (You could use the "blame" functionality of GitHub to find out the PR that added the functionality and read about the reasoning there)

from fastlane-plugin-ionic.

josh-m-sharpe avatar josh-m-sharpe commented on May 2, 2024
  1. Ok. It's still incorrect?
  2. ionic's support for build.json provides value. Should this plugin allow its use?

from fastlane-plugin-ionic.

janpio avatar janpio commented on May 2, 2024

Ok. It's still incorrect?

No. build is just prepare and compile run after each other, so it is technically not incorrect. But I clarified in the README which commands it really runs: 77a01a7

ionic's support for build.json provides value. Should this plugin allow its use?

This plugin just executes the Ionic CLI, so everything the CLI supports, this plugin also supports.

What exactly are you doing and what is not working? iOS or Android? Can you share your project on GitHub?

from fastlane-plugin-ionic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.