Giter Site home page Giter Site logo

Comments (18)

joshdholtz avatar joshdholtz commented on May 6, 2024 2

@bdrelling Thank you, thank you! I've been holding "Fastlane Friday Office Hours" on my Twitch channel (https://www.twitch.tv/joshdholtz) past two Fridays and will try to be every future Friday where I answer anyones questions live and if no one has questions I work on Fastlane PRs so that is why you've been seeing more activity lately 😊 Feel free to drop by my stream on Friday if you need any help with anything!

from fastlane-plugin-s3.

waltermvp avatar waltermvp commented on May 6, 2024 2

@cupojoe yep was missing the       
html_template_path: 'fastlane/deploy_html_templates/s3_ios_html_template.erb'

you mentioned. Thanks

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024 1

@cupojoe Ahhhhhh yeah yeah! I can change that today 👌

from fastlane-plugin-s3.

bdrelling avatar bdrelling commented on May 6, 2024 1

@joshdholtz Damn man, you're crushing some work on this in the past few days. Thanks for the support!

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

You can use these action params - https://github.com/joshdholtz/fastlane-plugin-s3/blob/master/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb#L35-L36

Sorry, documentation on that is not the best right now 😇

from fastlane-plugin-s3.

bdrelling avatar bdrelling commented on May 6, 2024

Had this same question, this is great. Thanks! Is there also some option to not deploy the HTML at all if we just want to do that ourselves outside of AWS? Just html_template_path = "" but leave upload_metadata = true?

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

Thanks!

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

@bdrelling Had no idea that was a bonus feature 😊 Thanks for even letting me know!

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

@joshdholtz Maybe a good default addition would be build number.

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

@cupojoe Where do you want the build number to be added to? 🤔

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

@bdrelling There is not a way to skip the HTML uploading right now but I can add that today!

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

@bdrelling 0.2.7 has your skip_html_upload parameter in it 💪

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

@joshdholtz I think here:
https://github.com/joshdholtz/fastlane-plugin-s3/blob/master/lib/assets/s3_ios_html_template.erb#L58

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

@joshdholtz How would I install the plugin with this changes?

Also, when referencing a custom html_template, running locally it works fine, but when running on bitrise (CI) it doesn't. The path is relative to the root of the project, right?

Edit: never mind about the path, figured it out. Relative path to the root of the project.

from fastlane-plugin-s3.

joshdholtz avatar joshdholtz commented on May 6, 2024

@cupojoe You probably need to run bundle update if you are using a Gemfile

from fastlane-plugin-s3.

waltermvp avatar waltermvp commented on May 6, 2024

@cupojoe did you ever get this working? I am having trouble passing in app_directory: "path/to.html.erb" to aws_s3 in the fastfile

and the file looks like so

    <!-- app/assets/html/sample.html.erb -->
<!doctype>
<html>
<head>
<%= stylesheet_link_tag "application" %>
</head>

<body>
<p>This is a sample static html page.</p>
</body>

</html>

am i missing something?

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

@waltermvp did you get it to work?

from fastlane-plugin-s3.

cupojoe avatar cupojoe commented on May 6, 2024

Awesome!

from fastlane-plugin-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.