Comments (13)
Will push a new release, thanks
from trainer.
New release is live, let me know if it works
from trainer.
Will do!
from trainer.
Still seeing this issue. fastlane-plugin-trainer 0.4.1, fastlane 2.165.0
from trainer.
Having the same issue.. although Status 65 appears to be a fastlane bug with scan
from trainer.
Same here @SlaunchaMan. I've dug through the trainer
gem logic and I can't find where the fail_build
option is actually used. It's certainly specified in options.rb
, but it doesn't look like it's being pulled out. Design flaw?
Are you also using the fastlane-plugin-trainer
like I am @SlaunchaMan? After more investigation, I think the issue is there. It's throwing a Unit tests failed
error if any of the tests failed in trainer_action.rb. That's probably the core issue.
@KrauseFx does that line up? If yes, I'd be happy to put together a PR to fix the issue. I'd assume we'd just want to avoid throwing that error if fail_build
is false
.
from trainer.
@cnoon Yes, I am using it with the Fastlane plugin. Fingers crossed on a fix! 😄
from trainer.
Okay, looks like this issue was fixed in 8b8a755. What's super weird is that the fix is in master
and what looks like would be 0.8.1
, but that's definitely not in 0.8.1
when you look. Almost looks like the rubygem released as 0.8.1
is not correct.
from trainer.
I bet if you pointed your Gemfile at the repo and not at the release it would work. I'm going to give that a go now. I've never released a gem before, but I wonder if it's possible to release the wrong commit. It doesn't appear that this project uses git tags for tracking.
from trainer.
Okay, more updates. I was off on my versioning a bit mentioned above. It appears that the trainer
gem has been released as 0.8.1
, but the fastlane-plugin-trainer
gem has not been released since April 2017 and is still at 0.4.0
. That's why it does not contain the fixes. Essentially, we need a new tag cut of the fastlane-plugin-trainer
gem and we'd be all good to go. @KrauseFx is that something you could help out with? Or someone else with access?
In the meantime @SlaunchaMan, you can work around the issue by updating your Pluginfile
to this:
gem "fastlane-plugin-trainer", :git => "https://github.com/KrauseFx/trainer.git", :ref => "28ddc18b"
That will pick up the fail_build
logic and stop failing if there are failed tests. I've verified that this does fix the issue locally. Good luck!
from trainer.
Awesome, thanks @KrauseFx! 🍻
from trainer.
we still experience the same issue with fastlane-plugin-trainer 0.4.1 and Fastlane 2.108.0 - see also #13 (comment)
from trainer.
Still seeing this issue as well. Looking in the plist file I see that xcode is outputting a FailureSummaries
block for the entire test target, including the error message. Other test target summaries get output normally. Trainer should be able to generate an <error>
block from this in the relevant test suite.
from trainer.
Related Issues (20)
- Trainer fails when Scan fails HOT 5
- Trainer succeeds even though one of the test targets of the scheme has failed HOT 1
- Cannot load such file -- fastlane HOT 9
- `Helper.gem_path` is deprecated. Use the `ROOT` constant from the appropriate tool module instead. HOT 1
- Add support for test failure formatting
- [ HOT 1
- [Feature Request] Dump crash file for a crashing test into JUnit failure node
- trainer fastlane plugin should mimic fastlane's scan behavior HOT 1
- unable to install: dependency unf_ext 0.0.7.5 ERROR failed to build gem native extension HOT 1
- Support for Xcode 11 HOT 17
- Bloated installation HOT 2
- Can't install trainer.
- can't find results with Xcode 11 HOT 5
- Support for XCTest skipping HOT 2
- Attachments support HOT 1
- xcpretty_naming does when test results are in a .xcresult file.
- Create outputs for number of tests executed
- Is this project still active, now that `trainer` has been incorporated into Fastlane? HOT 4
- Cannot load such file -- fastlane_core (LoadError) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trainer.