Case sensitivity needs to be handled in .xcovignore

[fastlane-community]

Case sensitivity needs to be handled in .xcovignore

[manas-chaudhari]

Turns out my pbxproj still contained old name :/
Fixed

[thelvis4]

I was about to push a solution for this already 😄

I still think it's a good idea to compare case-insensitively as we cannot have both TestFolder and testfolder in the same place. 🤔
@nakiostudio what do you think about this?

[manas-chaudhari]

In case we don't want to compare case-insensitively, perhaps a line in documentation mentioning that xcov reads path from pbxproj would help.

[thelvis4]

Not sure what reads path from pbxproj means in this context. 🤔
Can you give an example, please?

[manas-chaudhari]

Sure. Let me indicate the scenario where case sensitivity causes a problem.

In pbxproj file, the path value is common/AppDelegate.swift. It looks as follows:

EB5B31471E40617900EB190F /* AppDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = NetworkCommons.swift; path = common/AppDelegate.swift; sourceTree = SOURCE_ROOT; };

In my file system, and in git, the directory's name is Common with a capital C. In this scenario, if I want to ignore this file for code coverage, I need to add common/AppDelegate.swift in my .xcovignore.

Thus, when I said reads path from pbxproj, I meant that xcov will match the ignore paths to the path values specified in pbxproj and not those on the file system.

Of course, we can assume that pbxproj and file system can differ only wrt case, otherwise the build would fail.

[thelvis4]

@manas-chaudhari Thanks for the example and a good explanation. 🙌

When this scenario happens, I believe, it would be easier to reason that matching ignored files/folders happens case sensitively than to dig into the project file to find out what's the case of the files/folders we want to ignore.
Suddenly, having case insensitive matching makes even more sense. 😄
I will open the PR I planned to open yesterday.

[nakiostudio]

Thanks both @manas-chaudhari and @thelvis4 🙌

I agree with you @thelvis4, simplicity FTW :)