Disable submit for review

[fastlane]

Disable submit for review

[fastlanebot]

@KrauseFx commented

That's a good point and makes perfectly sense.
Right now, you can just comment out the ipa line.

I'll add an option for this later today, thanks for letting me know.

[fastlanebot]

@KrauseFx commented

@paweldudek seems to have implemented something like this already: https://github.com/paweldudek/deliver/commit/2a58241243513ba0dfda187332fad16e81391cf8

About the scary red button: You know you can very easily cancel the submission while Waiting for Review?

[fastlanebot]

@DenHeadless commented

@KrauseFx Yep, of course, but it's strange to cancel submission every time. At least for me, i would never want automatic submission for review, but it's very subjective, of course.

Anyway, thanks for great gem, it's a great addition to our build tools!

[fastlanebot]

@KrauseFx commented

@DenHeadless Yes, I understand that.
I'll be working together with @paweldudek to implement this feature.

[fastlanebot]

@paweldudek commented

@DenHeadless @KrauseFx should be able to bake a PR for this one tomorrow 😉

[fastlanebot]

@KrauseFx commented

Awesome, thanks @paweldudek. As mentioned on your commit: It's okay to just send a PR with the new option in the ipa_uploader. I'll implement the interface of the Deliverfile and update the README.

[fastlanebot]

@mgrebenets commented

Good to see progress on this request.

I just used deliver to upload an app and was puzzled when I realized that the ipa was actually submitted for review, not just uploaded.

For me the main concern was how did deliver answer the compliance questions. The one about encryption and another one about IDFA. For IDFA there's yes/no option and then 3 checkboxes of which I have to check only the first one, then there's "I contest" checkbox at the bottom.

It would be a nice improvement to have these answers configurable in Deliverfile.

And finally deliver could be used to upload ipa and then share it with beta testers via TestFlight.

P.S.
Thanks for an awesome gem! Keep up good work!

[fastlanebot]

@KrauseFx commented

@mgrebenets

Both things you mentioned are possible:

• Compliance Questions
• TestFlight

I have to admit, I'm not sure the Compliance Questions are working. You can create a separate issue in case it's not working.

[fastlanebot]

@mgrebenets commented

Cool, thanks for the links.
Right, there's no way to check compliance questions answers once the app is submitted for review, at least I can't find anything in iTC.

Probably taking screenshots of browser page with answers could be a valuable feature. To serve as reassurance for concerned developers.

[fastlanebot]

@KrauseFx commented

Do you mean deliver should take a screenshot of all opened pages and store them somewhere?

A screenshot of all available options can be found here.

[fastlanebot]

@mgrebenets commented

No, I don't mean to screenshot all the pages, just important ones. Like that page with answers to compliance questions.

[fastlanebot]

@KrauseFx commented

This functionality is now available in the master branch: fastlane-old/deliver#36

Please take a look at the bottom comments about how to install it. The new version was not yet released, still waiting for an okay from the other developers.

[fastlanebot]

@DenHeadless commented

Thank you very much!

[fastlanebot]

@KrauseFx commented

Can you try it and let me know if it works as expected?