Outstanding Items / Home Stretch

[fcc-alumni]

Outstanding Items / Home Stretch

[no-stack-dub-sack]

• toggling user image / skills & interests in Community view on mobile only toggles one way on iPhone: after revealing skills & interests you cannot toggle back to the avatar

@bonham000 have you tried touching the gutters? This does it on Android. Still not ideal, but I figured it out after toying around for a minute and my guess is that most users will as well...

@no-stack-dub-sack I tried I still can't get it to toggle back... Still, this is minor and could be ignored for now.

Resolved

[no-stack-dub-sack]

• there are some failed propTypes warnings in the console in various components

@bonham000 the only one I know of for sure is in community regarding fccCerts and this is because one of our "test users" made their profile private at some point during the dev of this app. Which reminds me, we still need to add a note during initial authentication that profile must also be public or fcc verification will fail.

EDIT: There's also this one, which just can't be helped:

warning.js:36 Warning: Failed prop type: Invalid prop `name` of value `` supplied to `Flag`.
Instead of ``, did you mean:
  - ad
  - ae
  - af

That one is coming from the country/flag drop down, and is there because I added a no selection option (---) which throws off the pre-managed component

EDIT # 2: Oh yeah, one more I knew about, also seems like it cannot be helped. This is about responsiveness in profile page. Semantic React component expects left or right, but we are only passing in right if isMobile is true. cannot use a ternary because we don't want left either way. So I think we'll just have to deal with this one.

• SUB-EDIT: I tried to overcome this with just a media query on the styled-component that renders this, but for some reason did not work as expected. Can't remember why though, so will likely try this again. If that works, it will just eliminate the need for using the floated prop. Worst comes to worst, we could always just replace the semantic-ui-react Button component with the regular HTML version, but this style of button seems to do better with the React component.

warning.js:36 Warning: Failed prop type: Invalid prop `floated` of value `false` supplied to `Button`, expected one of ["left","right"].

[bonham000]

I think we can optimistically bring this one to a close.