coding style guide

[fcc-alumni]

coding style guide

[theodesp]

You don't need to spend a lot of time on this. Just add eslint and agree on a basic config like airbnb style guide with some modifications.
http://eslint.org/docs/rules/
https://github.com/airbnb/javascript

You need to make sure linting is part of the build pipeline.

[bonham000]

@no-stack-dub-sack with the introduction of styled components (I still really have no idea how these work, by the way!), and otherwise a pretty diverse motley of styles — inline, sass, css, and our application of custom Semantic... etc. I think this would also be good, especially in relation to the Readme and Contributing guides we'll need to create: basically a uniformed set of guidelines on how you want people to implement styling, and maybe some work to make it more consistent in the codebase.

[no-stack-dub-sack]

@bonham000 I've been making this an effort in the back of my mind for some time now as I touch different parts of the codebase that I haven't touched in a while, i.e. making the style of the code more consistent. Will def have to put some deeper thought into this, but will be helpful to keep things clean when others start contributing

[stephenjfox]

Guys! I've been AWOL because of work-place unpleasantness.
Do we think there should be a formal write-up of the style guide? I've got some professional experience in that area...

[no-stack-dub-sack]

@stephenjfox I totally missed your last comment, wish I saw it back then. Hope everything has been good with you!

@theodesp originally, the issue was trying to get a custom config on top of Create-React-App's but I've since ejected and added a custom config which enforces the style rules that I care about for the most part. So going ahead and closing this.