Comments (9)
Oh sh*t.... never saw that one... I'll look it
Can you send me your config for my extension?
This began with 2.0.5?
Can you try install 2.0.4 and see if the bug persist?
from vscode-markdown-table-formatter.
Here are the settings for the extension as I have it now (pretty sure they're all the default values?): https://p-37FYgJ.b1.n0.cdn.getcloudapp.com/items/xQuDJOkp/Settings%20%E2%80%94%20Testing%20VSCode%202020-07-10%20at%2023.55.29.png?v=984f74941cba185152b41bd28d1a2a9f
Will try the previous version and report back.
from vscode-markdown-table-formatter.
Okay so after some quick tests, it seems like this has been an issue since 2.0. I went all the way back to 1.4.3, and that's the first version (going backwards in time) that had no lag, and no message in the console. Every other version (2.0.0 -> 2.0.5) had the lag, and the same message in the console.
from vscode-markdown-table-formatter.
Yikes, I changed a lot from 1 to 2. But mostly important to this case (I think):
- the packaging from multiple files to webpack;
- a dependency: xregexp from 3.2.0 to 4.2.4;
- the regex used to find the tables.
I never liked the fact that the extension is enabled on VSCode launch too, but to support enabling in any file type this is a must, but maybe it's time to change it... as this is called "markdown table formatter" it should be enabled only when markdown type files are opened.
I updated the regexp dependency to 4.3.0 because it said that it has better compatibility with web pack, and changed the activation to markdown only.. Can you test this one and check back please?
markdown-table-formatter-2.0.5.vsix.zip
from vscode-markdown-table-formatter.
@fcrespo82 I think that did the trick! I don't see any lag now with this version you provided.
from vscode-markdown-table-formatter.
Great, let's be sure, as I changed the activation event, follow the steps below and report back please.
- Start vscode with no folder or files opened
- Open or create a markdown file with a table and test the functionality of the extension
- Follow your steps to reproduce the bug
from vscode-markdown-table-formatter.
Okay so I might've jumped the gun since I didn't test the functionality of the extension before I said it worked before. While I can't reproduce the behavior exactly the way I saw it in the issue I brought up in the Vim extension (meaning, cold start, open settings.json
, lag with navigation until it times out with the message I noted above), I can still reproduce it by doing pretty much what you specified:
- I started VSCode with no folder or files opened
- I created a brand new markdown file, created a table, and then used the "Move Column Left" command, which worked fine.
- I then opened the
settings.json
file, and saw the same lag
from vscode-markdown-table-formatter.
Got it. I was afraid that would be the case.
My first thought was that the extension was slowing down the launch of the vscode. But apparently the bug is on another place. I'll investigate further, but I just had another idea that this may be reminiscent from the way the extension worked before using the formatter api, it trying to find table on all opened editors, not just on the language ones thus causing the slowness on the settings.json editor.
I will report back with any news soon.
Thanks for letting me know.
from vscode-markdown-table-formatter.
I think I got it now... It really was a path in the code were it would check for tables in any opened file regardless of the language.
Check with this version please markdown-table-formatter-2.1.0-beta.vsix.zip
from vscode-markdown-table-formatter.
Related Issues (20)
- Installation Problem HOT 4
- unable to format single column tables
- Formatting removes indentation of tables HOT 1
- Add an option to choose table separators spacing HOT 3
- Extension causes high cpu load HOT 10
- Numeric sort in tables HOT 4
- Unable to format with extension HOT 8
- First and last pipe are not kept when sorting HOT 1
- Open VSX HOT 2
- Backtick ` causes skipped cell HOT 1
- Mis-detecting code block as table HOT 1
- Feature Request: Add CodeLens to format table
- Doesn't work HOT 2
- Support heading separator with Spaces/Tabs HOT 6
- Feature request: Limit Last Column Width tied to header, not wordWrapColumn HOT 2
- Sort - Ignore Case HOT 2
- Add "sort" in actions - available via command palette HOT 1
- Wrong whitespace padding when formatting content with emojis
- apply on other plain-text tables too? HOT 1
- Feature request: jump to next column and format the table on [Tab] pressed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-markdown-table-formatter.