[BUG] Build Errors on Fedora after recent updates to Backlight.c & Backlight2.c

[hunterzero99]

[BUG] Build Errors on Fedora after recent updates to Backlight.c & Backlight2.c

[FedeDP]

Hi! The issue should be fixed in latest master.
Thanks!

[FedeDP]

Hi! Thanks for opening this bug report!
It seems like it is trying to build a ddcutil feature that is only available since ddcutil 1.2.0.
The weird thing is I am building Clightd on a ddcutil 1.2.0 laptop and a 1.1.0 one, and I'm not encountering such issue.
Code too looks fine to me.

Which ddcutil version are you on?

[hunterzero99]

Looks like the release in Fedora 35 is really outdated; it's installing ddcutil-0.9.9-5

Solution looks to be to build a more recent version of ddcutil from source.

[FedeDP]

Hi! It is weird anyway: Clightd does only build the new feature if ddcutil >= 1.2.0 is found, thus it is backward compatible!

The weird thing is I am building Clightd on a ddcutil 1.2.0 laptop and a 1.1.0 one, and I'm not encountering such issue.

With this sentence I meant that I'm already building a Clightd with the new monitor hotplug feature support, and ine without, and it builds fine!
May be you should clean your cmake cache? Ie: remove the build folder and start from scratch?

[FedeDP]

Moreover, archlinux is still on 1.1.0, thus every user building from AUR should've encountered your same issue (and, and as far as I know, nobody has!)

[FedeDP]

Can you share output of cat /usr/include/ddcutil_macros.h? Thank you!

[hunterzero99]

[user@acamar build]$ cat /usr/include/ddcutil_macros.h 
/** @file ddcutil_macros.h.in
 *
 *  Macros for checking ddcutil version at compile time. 
 *  The Autotools build system converts this file to ddcutil.macros.h 
 *  at build time. The version values are set from those in configure.ac. 
 */

// Copyright (C) 2018 Sanford Rockowitz <[email protected]>
// SPDX-License-Identifier: GPL-2.0-or-later


#define DDCUTIL_VMAJOR 0
#define DDCUTIL_VMINOR 9
#define DDCUTIL_VMICRO 9