Support Python3

[federicoceratto]

Support Python3

[FedericoCeratto]

Blocked by https://bitbucket.org/bbangert/beaker/issue/114/python3-raises-typeerror-passphrase-must

[jcdyer]

Looks like Beaker has moved to github. The above blocker ticket is now a broken link. See https://github.com/bbangert/beaker/

Possibly blocked by bbangert/beaker#21

[FedericoCeratto]

bbangert/beaker#21 is still unpatched and other required libraries are not available for Python3 at the moment.

[Hubro]

Any progress on this?

[glebourgeois]

Has python 3 compatibility been considered again ?

[FedericoCeratto]

Unfortunately the bug in Beaker has not been fixed so far. The offending code is there since 2008, and the project is not being actively maintained.
At this point, moving away from Beaker seems to be the only option. Any suggestion?

[Hubro]

I support moving away from dead and broken dependencies thumbsup

Tomas E. Sandven

On Sat, Oct 25, 2014 at 2:57 PM, Federico Ceratto [email protected]
wrote:

Unfortunately the bug in Beaker has not been fixed so far. The offending
code is there since 2008, and the project is not being actively maintained.
At this point, moving away from Beaker seems to be the only option. Any
suggestion?

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

[glebourgeois]

seems like a good idea, but don't know what replacement to use.

[oshihirii]

Hello,

I'm looking at Python 3 Wall of Superpowers which shows Bottle and Beakerhave Python 3 compatibility - specifically bottle 0.12.8 is compatible with Python 3.3 and Beaker 1.6.4 is compatible with Python 3.2.

Does this change things at all and make Cork compatible with Python 3?

Thank You.

[FedericoCeratto]

Bottle is indeed compatible with Python 3 while Beaker is still not entirely compatible (see bug listed above). Beaker has not been maintained since 2013 and the last release is from 2012.
Moving away from it seems to be the only option at this point.

[oshihirii]

Ok, thank you for the information, I would contribute time to look into it, but the operations of Beaker are a little out of my league I think. I will watch this topic with interest.

[FedericoCeratto]

Good news, @amol- is taking over Beaker and released a new version already:
https://github.com/bbangert/beaker/commits/master

[oshihirii]

Wow, thanks for the update. So is Beaker compatible with Python 3 yet, or still on the horizon?

[amol-]

Beaker 1.6 is compatible with some versions of PY3, see that on travis is already tested again 3.2: https://travis-ci.org/bbangert/beaker/builds/49749936

Support for PY3 in 1.6.5 is currently achieved using 2to3 and some fixes during installation, I worked on a fully native solution which is currently tested against all py3.2, py3.3, py3.4 https://travis-ci.org/TurboGears/beaker

The fully native solution will be released as soon as I have time to merge it back into the main trunk and test it on some real world project, in the mean while you can freely clone it from https://github.com/TurboGears/beaker/commits/py3native and send feedbacks if you find any issue.

[FedericoCeratto]

@oshihirii and @amol- the main blocker that is currently preventing Cork to use Beaker with python3 is bbangert/beaker#21 , which is still unpatched.

[FedericoCeratto]

Added patch bbangert/beaker/pull/75

[FedericoCeratto]

Beaker v1.7.0dev was released 19 days ago. Pending release of a stable version.

[glebourgeois]

not out yet ?

[FedericoCeratto]

Nope, the last activity from was releasing the dev version on 25 Feb.
@amol- : any plan to release a stable version soon? Thanks!

[amol-]

@FedericoCeratto no plans, waiting a reasonable span of time to confirm no major bugs have been introduced due to the rewrite. The changes were big so I need to confirm third party projects continue to work as before.

[FedericoCeratto]

@amol-: thanks for the reply. I'll import the dev version and test Cork on Python 3 against it.

[amol-]

@FedericoCeratto any feedback on testing beaker with Cork on py3? I plan to release Beaker as stable in a few days but wanted to wait for Cork feedback :)

[FedericoCeratto]

@amol-: I'm currently testing the new version and seems to be working. I'll publish the updated unit tests shortly.

[FedericoCeratto]

@amol- crypto.generateCryptoKeys(cleartext, salt, 10) is generating different hash values under python2.7 and python3.4 with Beaker 1.7 - is this expected?

[amol-]

It might yes, when hashlib.pbkdf2_hmac is available that is used otherwise a builtin pbkdf2 implementation is used. You can check on both interpreter with hasattr(hashlib, "pbkdf2_hmac") if the two provide different answers they will probably lead to different keys.

[FedericoCeratto]

@amol-: found the culprit: bbangert/beaker#81
Calling crypto.generateCryptoKeys with cleartext and salt as unicode strings produces the same output in py2 and py3 as expected. If I pass salt as a bytes type, it breaks due to the "bytes_" function

[amol-]

@FedericoCeratto fixed bbangert/beaker#81
Should I proceed with release or did you find any other issue?

[FedericoCeratto]

@amol- I haven't found anything else so far.

[FedericoCeratto]

Version 0.12.0a1 released with Python 3 support.

[FedericoCeratto]

Version 0.12.0a2 released