Giter Site home page Giter Site logo

Comments (3)

markpritchard avatar markpritchard commented on June 13, 2024

Thanks for the great bug report @jangernert . I've got a fair bit on at the day job at the moment, but I'll take a look this evening.

As an aside, I turned this on to simplify consumption of the feed programmatically (so clients didn't all have to trim whitespace themselves), but perhaps this is overeager on element transition as you mention. Anyway, will dig into it this evening.

Thanks again!

from feed-rs.

jangernert avatar jangernert commented on June 13, 2024

Would you accept a PR that just deactivates the white-space trimming for now? We can take further actions once issues because of it arise. But for now at least I don't see a disadvantage.

from feed-rs.

markpritchard avatar markpritchard commented on June 13, 2024

Sure, that is fine for now @jangernert .

I'm planning on releasing 0.3 in a little while which will introduce parsing of other namespaces (eg. DublinCore) to handle elements such as dc:date in rss1 feeds. This is a decent size change, which people may not want to opt into, so it will come with a configuration concept. This could be used to address the white-space trimming too.

Could you add a test case to ensure the updated white-space trimming meets your needs? That way we have a regression test for the future too.

Thanks!

from feed-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.