Giter Site home page Giter Site logo

Comments (6)

TimPansino avatar TimPansino commented on June 11, 2024

if [[ ${CONTAINER_PATCHES} ]]; then

Recommendation:

if [[ -n ${CONTAINER_PATCHES:-}" ]]; then

from foundryvtt-docker.

felddy avatar felddy commented on June 11, 2024

The problem is this line:

set -o nounset

I forgot to move it down below the new CONTAINER_PATCHES section.

But more importantly the automated testing was happy with this failure. The "Ready" text the tests are looking for was found earlier in the log, and was no longer a valid indicator of the system starting.

Good catch!

from foundryvtt-docker.

felddy avatar felddy commented on June 11, 2024

Undoing auto-close so @TimPansino can verify.

from foundryvtt-docker.

felddy avatar felddy commented on June 11, 2024

A new release is being built and tested. It should be out in a few minutes:
https://github.com/felddy/foundryvtt-docker/runs/823965856?check_suite_focus=true

Thanks again for catching this. Please let me know if this fix also works for you.

from foundryvtt-docker.

TimPansino avatar TimPansino commented on June 11, 2024

Everything looks good on my end. 👍

from foundryvtt-docker.

felddy avatar felddy commented on June 11, 2024

Sweet! Thanks!

from foundryvtt-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.