Params are not encoded

[fenok]

Params are not encoded

[fenok]

Hello and thank you for using the library!

This is indeed intentional for two reasons:

• I didn't want to encode too much. For instance, encodeURIComponent encodes &, which is a valid char in a pathname segment. I could implement custom encoding, but it seemed unnecessarily complicated.
• Values like "some/segment" are actually perfectly valid for star (*) params.

For now, you can use a custom type to add encoding:

// Only usable for pathname params
const encodedString: ParamType<string> = {
  getPlainParam(value) {
    // It's always guaranteed that value is not 'undefined' here.
    return encodeURIComponent(String(value));
  },
  getTypedParam(value) {
    // We could treat 'undefined' in a special way to distinguish absent and invalid params.
    if (typeof value !== 'string') {
      throw new Error('Expected string');
    }

    return decodeURIComponent(value);
  },
};

This is admittedly not ideal, since you really only want to alter the internal parser behavior. I'll think about adding an option for providing a custom parser to built-in types like string()

[andrejilderda]

@fenok I see, that makes sense. Thanks for providing a solution (which is much more elegant than what I came up with)!