[BUG] ScrollView in Pager causes partially shown views

[fermoya]

[BUG] ScrollView in Pager causes partially shown views

[fermoya]

@mohammad-rahchamani , I'm seeing it now and I can reproduce it, thanks. As far as I can see, the DragGesture.onEnded callback isn't called, ScrollView cancels the gesture. I've found a related issue, you can find it here. I can't really follow the same approach as GestureState gets reset before onEnded is called, so I wouldn't be able to animate the scrolling to the next page.

I'll think about possible solutions, any thought on your side are more than welcome

[fermoya]

I just released v1.9.0-beta.4 with a fix for this issue. You'll see that I'm ignoring swipes that aren't along the X-Axis ± 30 degrees and not starting the pagination if the total translation on the X-Axis isn't larger than on the Y-Axis

Hope it works.

[fermoya]

@mohammad-rahchamani , I'm running your code on both Xcode 11.5 and Xcode 12 Beta 2 and I don't see this issue you mention. See iPhone 8 - 13.5 on the left and iPhone 8 - 14.0 on the right:

movie.mov.zip

[mohammad-rahchamani]

Thank you for your fast response.
You have to drag diagonally for this to happen.
I'm trying to capture another demo with my pointer for more clarification.

[mohammad-rahchamani]

here is another demo with a visible gesture.

[mohammad-rahchamani]

@fermoya please take a look at my pull request.
I'm not able to reproduce the issue with this new change.

[carlosrc]

Same problem here!

[fermoya]

I’m working on it. I checked the PR but the issue kept happening.

I wanted to merge something first to avoid conflicts, I’ll be working on this promptly

[skt216]

Thank you. I am also facing the same issue

[carlosrc]

Thanks for the fix! Great work