Giter Site home page Giter Site logo

Comments (3)

adzza24 avatar adzza24 commented on August 23, 2024

Ok, so the mistake is this:

[type]="PieChart" >>> [type]="'PieChart'"

So its a stupid mistake on my part, but a check and error handling for @Input() type would be an excellent addition :)

from angular-google-charts.

FERNman avatar FERNman commented on August 23, 2024

This is an Angular error as far as I know and hopefully will be fixed in the future. They had type-checking for inputs already, but since 4.0 it's broken. See this feature request for more information.

Therefore I think its an overkill to do type-checking myself as Typescript should do that. Correct me if I'm wrong and it's good practice to do type-checking for inputs manually. For now, I'll close this.

from angular-google-charts.

adzza24 avatar adzza24 commented on August 23, 2024

No problem. It's not actually the type that needs to be checked just the existence of the variable which is called type. It probable doesn't matter, but I just thought a more descriptive error might be useful here. Great library though dude - thanks for setting this up.

from angular-google-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.