Addition of "engines": { "node": ">=0.12"} is a breaking change

[feross]

Addition of "engines": { "node": ">=0.12"} is a breaking change

[feross]

Sorry if that affected you. Background on the change is here: #2

It should only cause a warning -- not prevent installation.

[TattdCodeMonkey]

Your are correct, sorry. mistook the warning for an error and the real error was something else. My deepest apologies.

[bajtos]

Hello, I am convinced too that this was a breaking change that should have been released in a new major version per http://semver.org/ 😞 Projects depending on "is-buffer": "^1.0.0" and running on Node v0.10 will start reporting installation warnings.

Node v0.10 is still a supported LTS version with many users running on it.

For example, our API Framework http://loopback.io/ targets enterprise users where Node v0.10 is still very common. We use tools that depend on is-buffer (transitively via dependencies) and now we are getting a bunch of installation warnings because of this change. These warnings puts us, LoopBack maintainers into bad light, like we are lames that cannot fix warnings. But in fact, there is nothing we can do about them, unless we downgrade our dependencies to ancient versions that depend on 0.x version of is-buffer (assuming there were such).

@feross could you please unpublish [email protected] and re-publishing this breaking change as a new major version?

[feross]

@bajtos Adding a new install-time warning is not a breaking change -- everything will continue to work.

This package doesn't detect SlowBuffer correctly on Node v0.10 -- and that has always been the case -- so it's important to warn users about it. See #2 (comment) for background.

[bajtos]

@feross thank you for a quick reply! I have a different opinion on install-time warnings, I think it makes us (LoopBack maintaners) look lame like we cannot fix our dependencies to have a clean install. However, let's not waste our time discussing that, I am ok to agree that we disagree :)

I submitted a patch that fixes detection of SlowBuffer on Node v0.10, could you please take a look? #15