Comments (7)
What would "supporting" URL entail?
from simple-get.
auth
doesn't exist in URL
. Instead it has username
and password
keys that will need to be concatenated with an infixed ":".
Also, swapping the use of url.parse()
for new URL()
.
from simple-get.
I don't see the point of replacing something that works in all versions of node with something that works only in Node v7. Why exactly would we want to use new URL()
?
from simple-get.
Because url.parse()
is on track to being deprecated.
from simple-get.
I highly doubt that url.parse()
will ever be deprecated, due to the massive effect on the ecosystem. But if that day does come, we can easily fix it at that time.
Isn't this just an implementation detail anyway? How does it affect your app?
from simple-get.
Using browserify bundles in url
. If it were using URL
, we could rely on window.URL
.
from simple-get.
Hm, that's actually a pretty nice benefit. Until it's more widespread though, this doesn't seem worth it, as we'd still need to include a polyfill for URL
. We can revisit this in a year or so.
from simple-get.
Related Issues (20)
- support external piping HOT 3
- Promisify return value to allow async/await HOT 1
- How to figure out redirected URL?
- Do not follow Location headers for POSTs HOT 6
- timeout with HTTPS HOT 4
- Disable redirects
- Redirect bug
- Remove require('url') in favor of URL HOT 2
- basic auth support HOT 3
- Using simple-get in IONIC HOT 1
- Option to skip body decompression HOT 1
- JSON.parse error for 204 status code (no content)
- From http client to undici? HOT 1
- HTTP 500 response not returned with Node.js 14 and concat HOT 1
- Switch from querystring to URLSearchParams
- Switch to esm?
- SyntaxError: API error: Unexpected token < in JSON at position 0 HOT 1
- TypeScript types HOT 1
- Backport the recent security fix to 3.x HOT 8
- Node.js v19 Breaking Change HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-get.