Giter Site home page Giter Site logo

URL support about simple-get HOT 7 CLOSED

feross avatar feross commented on June 15, 2024
URL support

from simple-get.

Comments (7)

feross avatar feross commented on June 15, 2024

What would "supporting" URL entail?

from simple-get.

stevenvachon avatar stevenvachon commented on June 15, 2024

auth doesn't exist in URL. Instead it has username and password keys that will need to be concatenated with an infixed ":".

Also, swapping the use of url.parse() for new URL().

from simple-get.

feross avatar feross commented on June 15, 2024

I don't see the point of replacing something that works in all versions of node with something that works only in Node v7. Why exactly would we want to use new URL()?

from simple-get.

stevenvachon avatar stevenvachon commented on June 15, 2024

Because url.parse() is on track to being deprecated.

from simple-get.

feross avatar feross commented on June 15, 2024

I highly doubt that url.parse() will ever be deprecated, due to the massive effect on the ecosystem. But if that day does come, we can easily fix it at that time.

Isn't this just an implementation detail anyway? How does it affect your app?

from simple-get.

stevenvachon avatar stevenvachon commented on June 15, 2024

Using browserify bundles in url. If it were using URL, we could rely on window.URL.

from simple-get.

feross avatar feross commented on June 15, 2024

Hm, that's actually a pretty nice benefit. Until it's more widespread though, this doesn't seem worth it, as we'd still need to include a polyfill for URL. We can revisit this in a year or so.

from simple-get.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.