Comments (8)
Fixed in the latest release
from formous.
Thanks. I'm using webpack and uglify. Shouldn't that code be automatically removed because it's related to the tests (I checked the latest commit diff) or am I misunderstanding something?
from formous.
Not those kinds of tests. The code in dx.js
is "developer experience" related, which just provides a bunch of checks to make sure that a developer is using Formous properly. And it's checking to make sure the Formous tests are listed in the correct order (non-critical always after critical tests).
from formous.
Should use NODE_ENV !== production
for that probably?
I just checked, the latest update increased my webpack bundle size (after uglify) about ~80 KB. I'm guessing the complete lodash is getting included. (#18 is a fix)
from formous.
Should use NODE_ENV !== production for that probably?
Ah, yes! Very good point. I'll add it when I get time, or you're welcome to do a PR.
I just checked, the latest update increased my webpack bundle size (after uglify) about ~80 KB. I'm guessing the complete lodash is getting included.
Another good point. I see you just did a PR for this, I'll check it out.
from formous.
I'll check what they do in other libraries and try to make a PR.
Do you dogfood this library?
from formous.
Yep, all my repos are dogfooded. :) I usually build them out of a need I have, and then release it publicly.
BTW, I would try to limit the amount of PRs for now. I have a big code health update planned when I have time, which will probably change 20-25% of the codebase. At some point I'll also add support for dropdowns and radio buttons as well.
from formous.
Great, hope to see something for #14 soon
from formous.
Related Issues (13)
- setDefaultValues still renders without default HOT 3
- HTML demo page HOT 1
- Bug: inputs don't get validated on enter/return key HOT 2
- pass formStatus to wrapped component
- Working with nested form fields and default form values in this.state HOT 2
- Would like to display submit button disabled if invalid HOT 1
- Using failProps with react-bootstrap?
- Support checkboxes HOT 3
- Suggestion on package name HOT 2
- How to force to show field errors when first time hit submit HOT 1
- Something is breaking server-side rendering HOT 4
- Usage of HOC HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formous.