Z-index and position

[lencioni]

Z-index and position

[glennfu]

Can't you just use CSS for this yourself outside the javascript plugin?

[lencioni]

I don't believe there is a very good way to select the spinner.

[glennfu]

In css:

.spinner {
    color: black;
    display: inline-block;
    height: 44px;
    width: 44px;
}
.spinner.someclass {
    color: white;
}

In html:

<div class="spinner"></div>
<div class="spinner someclass"></div>

In js:

$(".spinner").spin();

This works on my spinners!

[lencioni]

Sure that works, but I shouldn't need to add extra markup to use the spinner.

[okize]

I added this to Spinner.defaults:
className: 'spinner',
And this:
el.setAttribute('class', self.opts.className);
Right before
el.setAttribute('aria-role', 'progressbar');

That adds a class of 'spinner' to the outermost div, which you can use to select and set z-index & positioning (will need to use !important for 'top' and 'left' to override inline style.

[andyburke]

Love this spinner, but I wanted to put in an upvote on this issue as well. I have some really tall elements that I'd like to be able to spin on, and instead of centering vertically, I'd like to just be able to set a vertical offset from the top of the element.

Maybe if the option 'vertical-offset' were set to something it could override the vertical centering?

[lencioni]

Just adding a class to the spinner automatically would be helpful, then I could target it in my CSS.

[glennfu]

I still don't see the issue personally. Assuming you're using a selector to find the elements you want to attach the spinner to, then you can use the same selector in CSS. If you're not using a selector and instead are manually targeting every place you want to apply the spinner in your javascript, then I personally think that's poor form and you'll find it gets really annoying later on as the project grows and you use it in more places.

On the other hand, if you don't like my idea, then I prefer ozike's method of adding a global classname to all the spinners.

[andyburke]

Created a pull request to address this issue: #55

[fgnass]

There are now new config options in 1.2.4: zIndex, className, top and left.

[lencioni]

Thanks Felix!

[andyburke]

I agree with the rename to top/left (vs. the topOffset/leftOffset from my patch), but I feel like they should just take valid CSS settings and not add the px. So, for instance, I should be able to do:

top: '50%'

[etuan]

top: '50%' would be awesome.

[jbetances]

Is there a way to both have the spinner going and at the same time be able click at other elements within the page?