I made a jQuery plugin that merges your options into the defaults

[jblotus]

I made a jQuery plugin that merges your options into the defaults

[fgnass]

The defaults already get merged into the provided options object inside the Spinner constructor:
https://github.com/fgnass/spin.js/blob/gh-pages/spin.js#L142

The jQuery plugin only calls $.exdend in order to fill in the runtime-color in case no color value has been explicitly specified.

[jblotus]

the issue is that that jquery plugin featured on the spin.js demo page wont
run unless you provide defaults explicitly.

On Wed, Mar 21, 2012 at 10:50 AM, Felix Gnass <
[email protected]

wrote:

The defaults already get merged into the provided options object inside
the Spinner constructor:
https://github.com/fgnass/spin.js/blob/gh-pages/spin.js#L142

The jQuery plugin only calls $.exdend in order to fill in the
runtime-color in case no color value has been explicitly specified.

---

Reply to this email directly or view it on GitHub:
#59 (comment)

[jblotus]

the issue is that that jquery plugin featured on the spin.js demo page wont run unless you provide defaults explicitly.

if (opts !== false) {
  data.spinner = new Spinner($.extend({color: $this.css('color')}, opts)).spin(this);
}

[jblotus]

i didn't realize the spin.js merged in options already. still there is a problem with the jquery plugin. it could be rewritten like so:

$.fn.spin = function(opts) {

  this.each(function() {
    var $this = $(this),
        data = $this.data();

    if (data.spinner) {
      data.spinner.stop();
      delete data.spinner;
    }

    data.spinner = new Spinner($.extend({color: $this.css('color')}, opts || {})).spin(this);
  });
  return this;
};

[fgnass]

I'm not sure what you mean. Here's an example that uses the jQuery plugin from the spin.js homepage: http://fgnass.github.com/spin.js/example/jquery.html

It works also when no options are passed at all. What problem exactly are you experiencing?

[jblotus]

your example clearly works. we were having trouble with it on our project. i will let you know what happened as soon as i can put together a test case.

thanks!

[fgnass]

You're welcome. I'll leave this issue open so that you can come back and post your test case.

[jblotus]

I have just tried to reconstruct the issue but I have failed. Looking more closely at the code, opts === false will still run if opts is undefined.

I think this was a red herring. Sorry to waste your time!