Giter Site home page Giter Site logo

Comments (6)

fgnass avatar fgnass commented on June 3, 2024

I also considered that option but decided to go for the singe-file solution as stripping the VML part only saves about 380 bytes after gzipping. And since it adds an extra request for the browsers which are already the slowest ones, I thought having a single file would offer the best trade-off.

from spin.js.

dlikhten avatar dlikhten commented on June 3, 2024

I was thinking more of having two files: ie.js and non-ie.js

Using ie conditional comment fun we guarantee that only one of the two requests is made. Ie will request ie.js and everyone else non-ie.js. This way 1 request, bytes saved, everyone is happy. Potentially some code could be avoided as well because we are guaranteed to be in IE vs not.

from spin.js.

dlikhten avatar dlikhten commented on June 3, 2024

Whopse closed issue.

from spin.js.

aseemk avatar aseemk commented on June 3, 2024

Just a thought experiment: how many extra bytes are needed for the conditional comment code? =D

from spin.js.

teddyzetterlund avatar teddyzetterlund commented on June 3, 2024

Not worth it. The conditionals themselves would add at least 110+ bytes (so we'd save maybe ~270 bytes) and four extra lines of ugly code compared to one clean script tag. My opinion is that it's enough that modern browsers skips the parsing of the IE specific bit.

from spin.js.

dlikhten avatar dlikhten commented on June 3, 2024

Good point...

from spin.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.