Comments (6)
I also considered that option but decided to go for the singe-file solution as stripping the VML part only saves about 380 bytes after gzipping. And since it adds an extra request for the browsers which are already the slowest ones, I thought having a single file would offer the best trade-off.
from spin.js.
I was thinking more of having two files: ie.js and non-ie.js
Using ie conditional comment fun we guarantee that only one of the two requests is made. Ie will request ie.js and everyone else non-ie.js. This way 1 request, bytes saved, everyone is happy. Potentially some code could be avoided as well because we are guaranteed to be in IE vs not.
from spin.js.
Whopse closed issue.
from spin.js.
Just a thought experiment: how many extra bytes are needed for the conditional comment code? =D
from spin.js.
Not worth it. The conditionals themselves would add at least 110+ bytes (so we'd save maybe ~270 bytes) and four extra lines of ugly code compared to one clean script tag. My opinion is that it's enough that modern browsers skips the parsing of the IE specific bit.
from spin.js.
Good point...
from spin.js.
Related Issues (20)
- No spin.min.js found for spin.js v4.0.0 HOT 1
- spinner never shows up for me HOT 2
- How do we change to font awesome spinner fa fa-spinner fa-spin? HOT 1
- Spin do not show animation in UI after updating Bootstrap and jQuery HOT 2
- please make sure newest versions are CDNs. HOT 7
- Since I upgrade the script the spin does not stop anymore.. HOT 4
- Pointers on how to use in Vue HOT 1
- problem
- div issue / undefined HOT 1
- Spinner looks weird when centered on odd number parent container widths... HOT 1
- NO spin.js HOT 2
- IE 11 Spinner Not Showing HOT 2
- Need to change spinner color HOT 1
- Sveltekit Vite error: SyntaxError: Unexpected token 'export'
- browserify HOT 1
- Uncaught SyntaxError: Unexpected token 'export' (at spin.js:82:1) HOT 2
- add mask
- Improving Documentation Website Font Legibility and Design
- Spinner Percentage Not Increase Continously In Increasing Order
- How Can I Remove Spinner In Spin.js? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spin.js.