mpc-qt support

[fichtefoll]

mpc-qt support

[FichteFoll]

Both your mentioned issues are fixed upstream. You'll need a version built from master to use them, of course. I declared support for mpc-qt in 1d944c6 and added an icon to my app.

[FichteFoll]

Thanks for the reports. I'll look into them in due time.

Do you know whether mpc-qt has some kind of icon for its name? I'd like to add that to the icon list if there is one, once I confirmed it is working properly.

[BobbyWibowo]

It doesn't have any fancy icon that I'm aware of. At the moment it's using this icon, including for the occasional Windows releases (it's an SVG though, so you may have to manually make a PNG version or something?). I think I'd also prefer having that icon used instead.

[BobbyWibowo]

Hi again, so I happened to be free and wanted to look more into it. I managed to figure out the issue. For mpc-qt, its position timestamp will always be in milliseconds instead of microseconds, so it'll always be converted to 00:00. Thus adding a patch where its position will be multiplied by 1000 if the active player is mpc-qt would solve it.
It feels kinda awkward having a special treatment for it tho, but oh well.
Here's some sneak peeks:

(kinda ended up making my own Discord app to have mpc-qt logo)
https://github.com/BobbyWibowo/discordrp-mpris/commits/mpc-qt-patch

[FichteFoll]

At the moment it's using this icon

I'll take it.

its position timestamp will always be in milliseconds instead of microseconds

Ah well, that was unexpected. I submitted a PR upstream so I don't have to add a workaround myself, since I could run into issues when that gets fixed and I still have the workaround in place. See https://github.com/cmdrkotori/mpc-qt/pull/203. Hopefully that'll get released fast enough for people using it (assuming they're not on debian or something).

I also added https://github.com/cmdrkotori/mpc-qt/issues/204 because fixing that myself wouldn't be as quick. However, I can add a reasonably simple workaround for this, similar to BobbyWibowo@9451315.

From BobbyWibowo@48ff085 I presume clementine is supported, too? I'll test that (and add an icon) as well, if it works. I can't test the KDE Plasma stuff though because I'm not running that and would probably need a VM. If you say these work, that's probably good enough.