Do we need the value attribute at all?

[fikaproductions]

Do we need the value attribute at all?

[WhippetsAintDogs]

You are right. When I first started this plugin, I didn't have any knowledge of the inner workings of Cockpit, neither of GatsbyJS (I was building it before even doing my first project with both technologies 😂). So, the main reason for keeping all those superfluous fields was that I didn't know if they were going to be useful or not to the end user at that time.

That being said, I agree that cutting them out is a necessity, but I don't think that keeping the option for backwards compatibility is required. Since the beginning of this project, I've always bumped the 'patch' version of this package (1.0.0 → 1.0.X → 1.0.11) since we were only working on the collection aspect of Cockpit. In the future, I intend to bump minor versions for anything else like the singletons, maybe the user/asset nodes as well. I think that we could bump a major version for this change (the value/type fields removing) in order to advertise that this is going to be a breaking change.

https://docs.npmjs.com/about-semantic-versioning

[DigitalGoldfish]

Okay great - I admit that I did expect more pushback on this issue and that's why I proposed the backwards compatiblity but if we can omit it that's fine with me too. :)

[DigitalGoldfish]

I started implementing this today and it should be ready for review/testing after the weekend.

[WhippetsAintDogs]

Great ! Thanks @DigitalGoldfish, it's going to simplify the queries a lot :)

[michaelpanik]

Hey @DigitalGoldfish any update on this? I'm starting a Cockpit/Gatsby project and it would make the queries a lot simpler!

[eXaminator]

Just to add another view to this: The type field CAN be useful! I use it to determine if a field is a WYSIWYG field and do some processing on it, like extracting links and images to have them be handled by gatsby.

For this reason I would suggest to add a simplified object that only contains the values but also keep the old fields object with the type for more specific handling.

[DigitalGoldfish]

Sorry, I don't even remember what happened that stopped me from finishing this. But we mostly moved away from Cockpit. I though remember that I already had the "value"-less syntax implemented in my fork so I guess i can dig that out again ...

Here is the link: https://github.com/MangoArt/gatsby-source-cockpit

Not sure how helpful this is ...