Comments (7)
You are right. When I first started this plugin, I didn't have any knowledge of the inner workings of Cockpit, neither of GatsbyJS (I was building it before even doing my first project with both technologies 😂). So, the main reason for keeping all those superfluous fields was that I didn't know if they were going to be useful or not to the end user at that time.
That being said, I agree that cutting them out is a necessity, but I don't think that keeping the option for backwards compatibility is required. Since the beginning of this project, I've always bumped the 'patch' version of this package (1.0.0 → 1.0.X → 1.0.11) since we were only working on the collection aspect of Cockpit. In the future, I intend to bump minor versions for anything else like the singletons, maybe the user/asset nodes as well. I think that we could bump a major version for this change (the value/type fields removing) in order to advertise that this is going to be a breaking change.
https://docs.npmjs.com/about-semantic-versioning
from fika-gatsby-source-cockpit.
Okay great - I admit that I did expect more pushback on this issue and that's why I proposed the backwards compatiblity but if we can omit it that's fine with me too. :)
from fika-gatsby-source-cockpit.
I started implementing this today and it should be ready for review/testing after the weekend.
from fika-gatsby-source-cockpit.
Great ! Thanks @DigitalGoldfish, it's going to simplify the queries a lot :)
from fika-gatsby-source-cockpit.
Hey @DigitalGoldfish any update on this? I'm starting a Cockpit/Gatsby project and it would make the queries a lot simpler!
from fika-gatsby-source-cockpit.
Just to add another view to this: The type field CAN be useful! I use it to determine if a field is a WYSIWYG field and do some processing on it, like extracting links and images to have them be handled by gatsby.
For this reason I would suggest to add a simplified object that only contains the values but also keep the old fields object with the type for more specific handling.
from fika-gatsby-source-cockpit.
Sorry, I don't even remember what happened that stopped me from finishing this. But we mostly moved away from Cockpit. I though remember that I already had the "value"-less syntax implemented in my fork so I guess i can dig that out again ...
Here is the link: https://github.com/MangoArt/gatsby-source-cockpit
Not sure how helpful this is ...
from fika-gatsby-source-cockpit.
Related Issues (20)
- Default values for "empty"/"unset fields
- allCockpit* returns each node twice HOT 7
- Missing "Meta" on Image-Gallery HOT 2
- error Plugin @fika/gatsby-source-cockpit returned an error HOT 2
- Argument filter has invalid value HOT 1
- How to get the person who last modified an entry HOT 2
- wysiwyg inserted photo does not show up HOT 1
- Undefined returned when trying to access gallery HOT 2
- Tags HOT 3
- Sort Order for Custom Sorted Entries HOT 1
- Error: BaseUrl config parameter is invalid or there is no internet connection HOT 2
- Error when using nested collection entries HOT 4
- Support for populate
- 404 error if you have a singleton with no fields HOT 2
- No value attribute for image and gallery field type HOT 2
- Error when using `collectionLink` component HOT 6
- my inline image of markdown from cockpit cms is not transformed by gatsby-remark-image or by gatsby-remark-images-anywhere HOT 1
- "Invalid asset url" when cockpit is installed in subfolder
- we need update to gatsby 3
- @fika/gatsby-source-cockpit is not compatible with your gatsby version 3.4.1 - It requires [email protected]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fika-gatsby-source-cockpit.