Comments (2)
I've seen this happen once or twice too. But running it again, doesn't seem to happen.
$ vendorcheck ./...
... (bunch of dependencies not vendored) ...
[!] dependency not vendored: github.com/miekg/dns
$ gvt fetch <a few of the dependencies listed above>
$ gvt fetch github.com/miekg/dns
2017/05/27 10:32:25 Fetching: github.com/miekg/dns
$ vendorcheck ./...
... (bunch of dependencies not vendored) ...
[!] dependency not vendored: github.com/miekg/dns
... (bunch more dependencies not vendored) ...
It's in a different place in the package list (it was last the first time, in the middle the next time). Notice the dns package was still reported unvendored. But then I gvt fetch
'ed a few other dependencies and then again:
$ vendorcheck ./...
[!] dependency not vendored: github.com/flynn/go-shlex
[!] dependency not vendored: github.com/jimstudt/http-authentication/basic
[!] dependency not vendored: github.com/hashicorp/go-syslog
[!] dependency not vendored: github.com/gorilla/websocket
In other words, somehow it seems to have resolved itself even without doing anything related to that package.
from vendorcheck.
I think vendorcheck is correct here, but it's subtle and I should document it.
If you vendor package A, then import package B, which is not vendored, and package B imports package A, it will not import your vendored copy. It will "escape".
from vendorcheck.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vendorcheck.