Comments (6)
erikras
commented on May 26, 2024
1
Published fix in v1.0.1.
dist/react-final-form-html5-validation.es.js went from 730K to 5.4K. 😱
from react-final-form-html5-validation.
ryan-mahoney
commented on May 26, 2024
Another clue, when I build my project, it says:
[BABEL] Note: The code generator has deoptimised the styling of "/Users/ryanmahoney/Documents/ecommerce/app/node_modules/react-final-form-html5-validation/dist/react-final-form-html5-validation.es.js" as it exceeds the max of "500KB"
Removing react-final-form-html5-validation (by just aliasing it to `react-final-form in my webpack config) shaves off ~100Kb!
from react-final-form-html5-validation.
erikras
commented on May 26, 2024
That's pretty weird considering the actual code is < 3kb. Bundlephobia confirms it's almost 100kb unzipped. It sure looks like the peer deps are properly specified as "external" in the rollup.config.js. 🤔
from react-final-form-html5-validation.
ryan-mahoney
commented on May 26, 2024
Yeah, I wanted to be more helpful and open a PR w/ a fix, but I've not actually bundled a library with rollup before. Hope it's an easy fix, this is a great lib ;)
from react-final-form-html5-validation.
Andarist
commented on May 26, 2024
Fixed by #2
from react-final-form-html5-validation.
ryan-mahoney
commented on May 26, 2024
Will you be pushing a new version to NPM?
from react-final-form-html5-validation.
Related Issues (13)
- Why are the `...rest` properties not included in `input` HOT 4
- expose errorKeys
- Programmatically setting fields to valid values still shows validation error. HOT 1
- HTML5 Field validation is not invoked on external form submit
- Expand "why not add this functionality directly" section of readme to mention accessibility considerations
- Field continues to be required even after changing required prop to false HOT 2
- email validation HOT 1
- React 17 compatibility HOT 2
- Form validation do not run for untouched fields after initialValues change
- Async validate prop always skips HTML5 validations
- Failed to execute 'querySelector' on 'Element': 'input[name=company.country],textarea[name=company.country],select[name=company.country]' is not a valid selector. HOT 1
- Typescript types? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-final-form-html5-validation.