Comments (13)
Agree
from origami-build-tools.
Perhaps not assert presence of origami.json
as it would be nice not to punish non-origami components from using this tool.
from origami-build-tools.
Ah, yes, that's essential, since obt needs to be used for products.
from origami-build-tools.
So should this be optional under a config option?
from origami-build-tools.
No, we can just check it if it exists.
from origami-build-tools.
Ah, right
from origami-build-tools.
Alberto, could you action this one?
from origami-build-tools.
Should there also be one that checks the validity of the demo config.json? and should the jshint bit be part of the jsHint function or of the individual origamiJson and demoConfigJson checks?
from origami-build-tools.
I'm not convinced js hint is really needed as part of this. It's more about checking the required properties are set.
We can do the demo config separately.
from origami-build-tools.
Re js hint, there's not a lot you can get wrong when the file has to be valid JSON. I suggest running it through JSON.parse. Demo config would be more complicated, so best leave that out of this issue I think.
from origami-build-tools.
#101 has been merged
from origami-build-tools.
Nudging @matthew-andrews
from origami-build-tools.
Looks great! Fixed up o-promobox
.
from origami-build-tools.
Related Issues (20)
- v11 bug: package.json.name validation is too lax
- Orphaned Repository - For Archiving.
- Dependabot needs permission to see karma-proclaim HOT 1
- remove `obt init` HOT 2
- add tests for the `dev` command
- Long lines get truncated in terminal
- proposal: add sub-command help flags
- Improve the karma-scrumple error message when dependencies have not been installed HOT 1
- Bug: obt test -- TypeError: Cannot read property 'trim' of undefined
- Defer to the depended on version of create-origami-component
- Use component `.remarkrc.js`
- Require component lint configuration HOT 4
- Is it ok that component configuration is dynamically required? HOT 1
- major: throw an error when `obt verify` finds readme issues? HOT 1
- feature: verify demo compilation per brand
- feature: install demo dev dependencies instead of using the build service HOT 1
- Feature request: Improve component spec v1 error messaging
- Feature: improve error message when origami.json.demos is not an array
- Feature: check the built demo html is syntactically valid HOT 1
- Bug: obt v11 beta uses wrong logic for validating origami.json version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from origami-build-tools.