Giter Site home page Giter Site logo

Comments (13)

triblondon avatar triblondon commented on June 16, 2024

Agree

from origami-build-tools.

matthew-andrews avatar matthew-andrews commented on June 16, 2024

Perhaps not assert presence of origami.json as it would be nice not to punish non-origami components from using this tool.

from origami-build-tools.

triblondon avatar triblondon commented on June 16, 2024

Ah, yes, that's essential, since obt needs to be used for products.

from origami-build-tools.

AlbertoElias avatar AlbertoElias commented on June 16, 2024

So should this be optional under a config option?

from origami-build-tools.

triblondon avatar triblondon commented on June 16, 2024

No, we can just check it if it exists.

from origami-build-tools.

AlbertoElias avatar AlbertoElias commented on June 16, 2024

Ah, right

from origami-build-tools.

triblondon avatar triblondon commented on June 16, 2024

Alberto, could you action this one?

from origami-build-tools.

AlbertoElias avatar AlbertoElias commented on June 16, 2024

Should there also be one that checks the validity of the demo config.json? and should the jshint bit be part of the jsHint function or of the individual origamiJson and demoConfigJson checks?

from origami-build-tools.

triblondon avatar triblondon commented on June 16, 2024

I'm not convinced js hint is really needed as part of this. It's more about checking the required properties are set.

We can do the demo config separately.

from origami-build-tools.

triblondon avatar triblondon commented on June 16, 2024

Re js hint, there's not a lot you can get wrong when the file has to be valid JSON. I suggest running it through JSON.parse. Demo config would be more complicated, so best leave that out of this issue I think.

from origami-build-tools.

AlbertoElias avatar AlbertoElias commented on June 16, 2024

#101 has been merged

from origami-build-tools.

AlbertoElias avatar AlbertoElias commented on June 16, 2024

Nudging @matthew-andrews

from origami-build-tools.

matthew-andrews avatar matthew-andrews commented on June 16, 2024

Looks great! Fixed up o-promobox.

from origami-build-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.