Giter Site home page Giter Site logo

Comments (4)

texodus avatar texodus commented on September 26, 2024

Thanks for the report. This fix looks correct on sight read, do you want to open a PR? If not we can cherry-pick the changes from your fork.

from perspective.

abalabin-bamfunds avatar abalabin-bamfunds commented on September 26, 2024

I created a PR, not sure if that's ok given the contribution doc says a CLA is required. If not, just cherry pick the commits

from perspective.

texodus avatar texodus commented on September 26, 2024

Apologies, the CLA process documentation was deleted without warning (externally hosted). We've just updated the project to a DCO contribution model, which only requires you to affirm your contribution by using the -s flag with git commit -s.

However, te PR also failed lint so I went ahead and re-authored this in #2608, this will be in Perspective v2.10.1

from perspective.

abalabin-bamfunds avatar abalabin-bamfunds commented on September 26, 2024

Thanks, looking forward to the new version to be available. Will use DCO next time.

from perspective.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.