Giter Site home page Giter Site logo

Comments (4)

juliandescottes avatar juliandescottes commented on August 24, 2024

Does this mean SMP confuses the index.js from react-dom with another similar file ?
I see two options here:

  • ignore small files (kind of random but should work here)
  • improve the plugin to run in several steps:
    • a: mark all the purely duplicated files (without touching require statements)
    • b: if a require() points to a duplicate marked in step a, normalize it to always point to the same ID
    • c: repeat until no more duplicates are marked

from devtools-core.

jasonLaster avatar jasonLaster commented on August 24, 2024

original:

'use strict';

module.exports = require('react/lib/ReactDOM');

webpack:

'use strict';

module.exports = require(153);

from devtools-core.

clarkbw avatar clarkbw commented on August 24, 2024

With SMP gone, is this still an issue?

from devtools-core.

juliandescottes avatar juliandescottes commented on August 24, 2024

No, moreover we're already using react & react-dom 15.3 :)

from devtools-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.