Giter Site home page Giter Site logo

Comments (6)

bgirard avatar bgirard commented on May 20, 2024

Here's a relevant blog post:
https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html

I discussed with mstange how we should consider adding this, or something similar, to the JS frame names in the sampling similar to PROFILER_LABELs.

from profiler.

gregtatum avatar gregtatum commented on May 20, 2024

Do we have this information already in the profile, or do we need to update the Gecko Profiler first?

from profiler.

gregtatum avatar gregtatum commented on May 20, 2024

I'm going to amend the title to make it a bit more specific, I'm not sure a tab is the way to go on this, as we may be able to use our existing tabs.

from profiler.

mstange avatar mstange commented on May 20, 2024

I think we still need to add PROFILER_MARKER calls in the right places in Gecko. At the moment, performance.mark calls are directly translated into profiler markers, but I believe we don't create markers for performance.measure calls.

from profiler.

dmose avatar dmose commented on May 20, 2024

@mstange are you sure? I have yet to be able to make any calls to performance.mark in content space show up in the marker pane in perf-html.io. Granted I'm making my calls from the web console, so perhaps that's the problem...

from profiler.

gregtatum avatar gregtatum commented on May 20, 2024

I'm closing this, they have been instrumented with Bug 1357849. There is the open work-in-progress PR #275 for implementing a markers view, which will display the user timings in a better visualization than just a table.

from profiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.